skin/delete.svg - Issue 29519650: Issue 5540 - implement notification

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: skin/delete.svg

Issue 29519650: Issue 5540 - implement notification (Closed)

Patch Set: Created Aug. 23, 2017, 6:55 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <svg id="5dbfc7a9-72c4-4898-881d-75bf73a9a059" data-name="artwork" xmlns="http:/ /www.w3.org/2000/svg" viewBox="0 0 48 48"><title>delete</title><polygon points=" 42.71 6.71 41.29 5.29 24 22.59 6.71 5.29 5.29 6.71 22.59 24 5.29 41.29 6.71 42.7 1 24 25.41 41.29 42.71 42.71 41.29 25.41 24 42.71 6.71"/></svg>
	ire 2017/08/24 10:08:44 For some reason the weight/thickness of the icon s For some reason the weight/thickness of the icon seems much lighter than in the spec. This makes it quite difficult to see. ire 2017/08/24 10:08:44 The ID is invalid (starts with a number) The ID is invalid (starts with a number) saroyanm 2017/08/24 14:18:26 I've created a bitbucket issue for that -> https:/ Show quoted text On 2017/08/24 10:08:44, ire wrote: > For some reason the weight/thickness of the icon seems much lighter than in the > spec. This makes it quite difficult to see. I've created a bitbucket issue for that -> https://bitbucket.org/adblockplus/spec/issues/68 This shouldn't be blocker for this review though, we will fix it later as soon new SVG is provided. saroyanm 2017/08/24 14:18:26 I think the ID is redundant, I think this image wa Show quoted text On 2017/08/24 10:08:44, ire wrote: > The ID is invalid (starts with a number) I think the ID is redundant, I think this image wasn't optimised. ire 2017/08/25 09:59:45 Acknowledged. Show quoted text On 2017/08/24 14:18:26, saroyanm wrote: > On 2017/08/24 10:08:44, ire wrote: > > For some reason the weight/thickness of the icon seems much lighter than in > the > > spec. This makes it quite difficult to see. > > I've created a bitbucket issue for that -> > https://bitbucket.org/adblockplus/spec/issues/68 > This shouldn't be blocker for this review though, we will fix it later as soon > new SVG is provided. Acknowledged.
OLD	NEW

« new-options.js ('K') | « new-options.js ('k') | skin/new-options.css » ('j') | skin/new-options.css » ('J')