Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: new-options.html

Issue 29519650: Issue 5540 - implement notification (Closed)
Patch Set: Created Aug. 25, 2017, 11:03 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 <div class="dialog-content-block"> 367 <div class="dialog-content-block">
368 <h3></h3> 368 <h3></h3>
369 <div class="url"></div> 369 <div class="url"></div>
370 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 370 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
371 </div> 371 </div>
372 </div> 372 </div>
373 </div> 373 </div>
374 <!-- Placeholder element to determine when to wrap focus around --> 374 <!-- Placeholder element to determine when to wrap focus around -->
375 <span class="focus-last" tabindex="0"></span> 375 <span class="focus-last" tabindex="0"></span>
376 </div> 376 </div>
377 <!-- Notification -->
378 <div id="notification" aria-hidden="true" aria-live="polite">
379 <strong id="notification-text"></strong>
380 <button id="hide-notification" data-action="hide-notification" aria-label= "Close Notification"></button>
ire 2017/08/25 12:10:07 Sorry I didn't notice this before, but shouldn't t
saroyanm 2017/08/25 12:22:56 Thanks for bringing this up. There is no easy way
ire 2017/08/25 12:43:44 You're welcome :) A suggestion for now could be to
saroyanm 2017/08/25 13:22:08 Great idea :) Done.
381 </div>
377 </body> 382 </body>
378 </html> 383 </html>
OLDNEW
« no previous file with comments | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld