Issue 5540 - implement notification

new-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 517 matching lines @@
         alert(errors.join("\n"));
       else if (onSuccess)
         onSuccess();
     });
   }
 
   function openDocLink(id)
   {
     getDocLink(id, (link) =>
     {
-      if (id == "share-general")
-        openSharePopup(link);
-      else
-        location.href = link;
+      location.href = link;
     });
   }
 
   function switchTab(id)
   {
     location.hash = id;
   }
 
   function execAction(action, element)
   {
@@ skipping 340 matching lines @@
 
     getDocLink("subscriptions", (link) =>
     {
       setLinks("filter-lists-description", link);
     });
 
     E("custom-filters-raw").setAttribute("placeholder",
       getMessage("options_customFilters_edit_placeholder", ["/ads/track/*"]));
 
     // Help tab
-    getDocLink("faq", (link) =>
-    {
-      E("link-faq").setAttribute("href", link);
+    getDocLink("adblock_plus_report_issue", (link) =>
+    {
+      setLinks("report-issue", link);
+    });
+    getDocLink("adblock_plus_report_ad", (link) =>
+    {
+      setLinks("report-ad", link);
+    });
+    getDocLink("adblock_plus_report_bug", (link) =>
+    {
+      setLinks("report-bug", link);
+    });
+    getDocLink("reporter_other_link", (link) =>
+    {
+      setLinks("report-forum", link);
     });
     getDocLink("social_twitter", (link) =>
     {
-      E("link-twitter").setAttribute("href", link);
+      E("twitter").setAttribute("href", link);
     });
     getDocLink("social_facebook", (link) =>
     {
-      E("link-facebook").setAttribute("href", link);
+      E("facebook").setAttribute("href", link);
     });
     getDocLink("social_gplus", (link) =>
     {
-      E("link-gplus").setAttribute("href", link);
-    });
-    getDocLink("social_renren", (link) =>
-    {
-      E("link-renren").setAttribute("href", link);
+      E("google-plus").setAttribute("href", link);
     });
     getDocLink("social_weibo", (link) =>
     {
-      E("link-weibo").setAttribute("href", link);
-    });
-
-    // Set forum link
-    ext.backgroundPage.sendMessage({
-      type: "app.get",
-      what: "platform"
-    },
-    (platform) =>
-    {
-      ext.backgroundPage.sendMessage({
-        type: "app.get",
-        what: "application"
-      },
-      (application) =>
-      {
-        if (platform == "chromium" && application != "opera")
-          application = "chrome";
-
-        getDocLink(application + "_support", (link) =>
-        {
-          E("link-forum").setAttribute("href", link);
-        });
-      });
+      E("weibo").setAttribute("href", link);
     });
 
     E("dialog").addEventListener("keydown", function(e)
     {
       switch (getKey(e))
       {
         case "Escape":
           closeDialog();
           break;
         case "Tab":
@@ skipping 38 matching lines @@
   {
     let dialog = E("dialog");
     dialog.setAttribute("aria-hidden", true);
     dialog.removeAttribute("aria-labelledby");
     document.body.removeAttribute("data-dialog");
     focusedBeforeDialog.focus();
   }
 
   function showNotification(text)
   {
     E("notification").setAttribute("aria-hidden", false);

[ire, 2017/08/24 10:08:44]

The aria-live attribute could also be relevant here (see
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Reg...)

[saroyanm, 2017/08/24 14:18:25]

Agree

[saroyanm, 2017/08/24 18:40:54]

Done.

     E("notification-text").textContent = text;
     setTimeout(hideNotification, 3000);

[ire, 2017/08/24 10:08:43]

(Personal Opinion) I think 3 seconds is too short

[saroyanm, 2017/08/24 14:18:26]

That's specified in the specs, let's be consistent for now with specs to be able
to finish the page until it's not critical, but I agree that this is something
that make sense to bring to the discussion during the next meeting.

[ire, 2017/08/25 09:59:44]

Acknowledged.

   }
 
   function hideNotification()
   {
     E("notification").setAttribute("aria-hidden", true);

[ire, 2017/08/24 10:08:44]

NIT: Clear the textContent as well?

[saroyanm, 2017/08/24 14:18:26]

Yes, I'll update that.

[saroyanm, 2017/08/24 18:40:54]

Done.

+    E("notification-text").textContent = "";
   }
 
   function setAcceptableAds()
   {
     let option = "none";
     document.forms["acceptable-ads"].classList.remove("show-dnt-notification");
     if (acceptableAdsUrl in subscriptionsMap)
     {
       option = "ads";
     }
@@ skipping 363 matching lines @@
   });
   ext.backgroundPage.sendMessage({
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
              "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
   window.addEventListener("hashchange", onHashChange, false);
 }