Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: new-options.html

Issue 29519650: Issue 5540 - implement notification (Closed)
Left Patch Set: Created Aug. 25, 2017, 11:03 a.m.
Right Patch Set: Rebased Created Aug. 25, 2017, 1:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 </button> 289 </button>
290 <button class="i18n_options_customFilter_cancel" data-action="ca ncel-custom-filters"> 290 <button class="i18n_options_customFilter_cancel" data-action="ca ncel-custom-filters">
291 </button> 291 </button>
292 </div> 292 </div>
293 </div> 293 </div>
294 </section> 294 </section>
295 </div> 295 </div>
296 296
297 <!-- Help tab content --> 297 <!-- Help tab content -->
298 <div id="content-help" role="tabpanel" aria-labelledby="tab-help"> 298 <div id="content-help" role="tabpanel" aria-labelledby="tab-help">
299 <h1 class="i18n_options_faq_title"></h1> 299 <h1 class="i18n_options_tab_help"></h1>
300 <p class="i18n_options_faq_description"></p> 300 <p class="i18n_options_help_description"></p>
301 <p> 301 <section>
302 <a id="link-faq" class="i18n_options_faq_title" target="_blank"></a > 302 <h2 class="i18n_options_support_title"></h2>
303 </p> 303 <ul>
304 <h1 class="i18n_options_forum_title"></h1> 304 <li id="report-issue" class="i18n_options_report_issue"></li>
305 <p class="i18n_options_forum_description"></p> 305 <li id="report-ad" class="i18n_options_report_ad"></li>
306 <p> 306 <li id="report-bug" class="i18n_options_report_bug"></li>
307 <a id="link-forum" class="i18n_options_forum_link" target="_blank"> </a> 307 <li id="report-forum" class="i18n_options_report_forum"></li>
308 </p> 308 </ul>
309 <h1 class="i18n_options_media_title"></h1> 309 </section>
310 <p class="i18n_options_media_description"></p> 310 <section>
311 <p> 311 <h2 class="i18n_options_social_title"></h2>
312 <span id="share-general"> 312 <p class="i18n_options_social_description"></p>
313 <a id="link-twitter" target="_blank">Twitter</a> 313 <div id="social">
314 <a id="link-facebook" target="_blank">Facebook</a> 314 <ul id="social-general">
315 <a id="link-gplus" target="_blank">Google+</a> 315 <li><a id="twitter">Twitter</a></li>
316 </span> 316 <li><a id="facebook">Facebook</a></li>
317 <span id="share-chinese"> 317 <li><a id="google-plus">Google Plus</a></li>
318 <a id="link-renren" target="_blank">renren</a> 318 </ul>
319 <a id="link-weibo" target="_blank">weibo</a> 319 <ul id="social-chinese">
320 </span> 320 <li><a id="weibo">Weibo</a></li>
321 </p> 321 </ul>
322 <p>
323 <strong>
324 <span class="i18n_options_email"></span>
325 <a href="mailto:support@adblockplus.org">support@adblockplus.o rg</a>
326 </strong>
327 </p>
328 </div>
329 </section>
322 </div> 330 </div>
323 </div> 331 </div>
324 </div> 332 </div>
325 333
326 <!-- Dialog --> 334 <!-- Dialog -->
327 <div id="dialog" role="dialog" aria-hidden="true"> 335 <div id="dialog" role="dialog" aria-hidden="true">
328 <header> 336 <header>
329 <span id="dialog-title"> 337 <span id="dialog-title">
330 <span id="dialog-title-custom" class="i18n_options_dialog_custom_title "></span> 338 <span id="dialog-title-custom" class="i18n_options_dialog_custom_title "></span>
331 <span id="dialog-title-language-add" class="i18n_options_dialog_langua ge_title"></span> 339 <span id="dialog-title-language-add" class="i18n_options_dialog_langua ge_title"></span>
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 378 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
371 </div> 379 </div>
372 </div> 380 </div>
373 </div> 381 </div>
374 <!-- Placeholder element to determine when to wrap focus around --> 382 <!-- Placeholder element to determine when to wrap focus around -->
375 <span class="focus-last" tabindex="0"></span> 383 <span class="focus-last" tabindex="0"></span>
376 </div> 384 </div>
377 <!-- Notification --> 385 <!-- Notification -->
378 <div id="notification" aria-hidden="true" aria-live="polite"> 386 <div id="notification" aria-hidden="true" aria-live="polite">
379 <strong id="notification-text"></strong> 387 <strong id="notification-text"></strong>
380 <button id="hide-notification" data-action="hide-notification" aria-label= "Close Notification"></button> 388 <button id="hide-notification" data-action="hide-notification">
ire 2017/08/25 12:10:07 Sorry I didn't notice this before, but shouldn't t
saroyanm 2017/08/25 12:22:56 Thanks for bringing this up. There is no easy way
ire 2017/08/25 12:43:44 You're welcome :) A suggestion for now could be to
saroyanm 2017/08/25 13:22:08 Great idea :) Done.
389 <span class="i18n_options_notification_hide sr-only"></span>
390 </button>
381 </div> 391 </div>
382 </body> 392 </body>
383 </html> 393 </html>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld