Unified Diff: new-options.html
Issue 29519650:
Issue 5540 - implement notification (Closed)
Patch Set:
Created Aug. 23, 2017, 6:55 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« locale/en-US/new-options.json ('K')
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: new-options.html |
| =================================================================== |
| --- a/new-options.html |
| +++ b/new-options.html |
| @@ -374,5 +374,10 @@ |
| <!-- Placeholder element to determine when to wrap focus around --> |
| <span class="focus-last" tabindex="0"></span> |
| </div> |
| + <!-- Notification --> |
| + <div id="notification" aria-hidden="true"> |
| + <span id="notification-text"></span> |
| + <button data-action="hide-notification" id="hide-notification"></button> |
|
ire
2017/08/24 10:08:43
This button doesn't have an accessible name
ire
2017/08/24 10:08:43
It's part of our coding style to not omit optional
saroyanm
2017/08/24 14:18:25
Good point, I'll use aria-label="Close"
saroyanm
2017/08/24 14:18:25
I think we were overriding current -> https://goog
saroyanm
2017/08/24 18:40:53
Done.
ire
2017/08/25 09:59:44
Okay, that makes sense.
|
| + </div> |
| </body> |
| </html> |
« locale/en-US/new-options.json ('K')
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
