Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: new-options.html

Issue 29519650: Issue 5540 - implement notification (Closed)
Patch Set: Created Aug. 24, 2017, 6:39 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | new-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: new-options.html
===================================================================
--- a/new-options.html
+++ b/new-options.html
@@ -374,5 +374,10 @@
<!-- Placeholder element to determine when to wrap focus around -->
<span class="focus-last" tabindex="0"></span>
</div>
+ <!-- Notification -->
+ <div id="notification" aria-hidden="true" aria-live="polite">
+ <strong id="notification-text"></strong>
+ <button id="hide-notification" data-action="hide-notification" aria-label="Close"></button>
ire 2017/08/25 09:59:45 I think "Close Notification" is more clear
saroyanm 2017/08/25 11:04:19 Done.
+ </div>
</body>
</html>
« no previous file with comments | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | new-options.js » ('J')

Powered by Google App Engine
This is Rietveld