Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(360)

Issue 29522597: Issue 5515 - Adblock Plus Frontend Developer Job Description to upload on our Website (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by ire
Modified:
2 years, 3 months ago
Reviewers:
juliandoucette, Lisa
CC:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/web.eyeo.com
Visibility:
Public.

Description

Issue 5515 - Adblock Plus Frontend Developer Job Description to upload on our Website

Patch Set 1 #

Total comments: 10

Patch Set 2 : Implement content changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M includes/jobs/header.tmpl View 1 chunk +1 line, -0 lines 0 comments Download
A pages/jobs/adblock-plus-frontend-developer.md View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 8
ire
2 years, 3 months ago (2017-08-21 10:49:13 UTC) #1
ire
Ready
2 years, 3 months ago (2017-08-21 10:53:25 UTC) #2
juliandoucette
LGTM @Thomas will you please confirm that you have reviewed this content and you are ...
2 years, 3 months ago (2017-08-22 13:25:26 UTC) #3
Thomas Greiner
Yep, I reviewed the content. It appears to contain some odd punctuation and such but ...
2 years, 3 months ago (2017-08-22 17:54:32 UTC) #4
ire
On 2017/08/22 17:54:32, Thomas Greiner wrote: > Yep, I reviewed the content. > > It ...
2 years, 3 months ago (2017-08-24 07:35:26 UTC) #5
Lisa
Hi Ire, I made a few suggestions. Thanks! https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-plus-frontend-developer.md File pages/jobs/adblock-plus-frontend-developer.md (right): https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-plus-frontend-developer.md#newcode2 pages/jobs/adblock-plus-frontend-developer.md:2: description=We ...
2 years, 3 months ago (2017-08-24 13:07:49 UTC) #6
ire
Thanks Lisa! Julian, is this good to go? https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-plus-frontend-developer.md File pages/jobs/adblock-plus-frontend-developer.md (right): https://codereview.adblockplus.org/29522597/diff/29522598/pages/jobs/adblock-plus-frontend-developer.md#newcode2 pages/jobs/adblock-plus-frontend-developer.md:2: description=We ...
2 years, 3 months ago (2017-08-24 13:45:27 UTC) #7
juliandoucette
2 years, 3 months ago (2017-08-24 14:26:55 UTC) #8
LGTM

Yes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5