Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29522601: Noissue - Use includes instead of indexOf (Closed)

Created:
Aug. 21, 2017, 11:16 a.m. by Manish Jethani
Modified:
Aug. 21, 2017, 2:19 p.m.
Reviewers:
Sebastian Noack, kzar
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Use includes instead of indexOf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M ext/background.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/devtools.js View 1 chunk +4 lines, -4 lines 0 comments Download
M lib/filterComposer.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/notificationHelper.js View 2 chunks +2 lines, -2 lines 0 comments Download
M options.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Manish Jethani
Aug. 21, 2017, 11:16 a.m. (2017-08-21 11:16:56 UTC) #1
Manish Jethani
Patch Set 1 Using Array.prototype.includes instead of Array.prototype.indexOf where it makes sense. includes is almost ...
Aug. 21, 2017, 11:20 a.m. (2017-08-21 11:20:09 UTC) #2
Manish Jethani
On 2017/08/21 11:20:09, Manish Jethani wrote: > Patch Set 1 > > Using Array.prototype.includes instead ...
Aug. 21, 2017, 11:36 a.m. (2017-08-21 11:36:16 UTC) #3
Sebastian Noack
LGTM
Aug. 21, 2017, 12:17 p.m. (2017-08-21 12:17:42 UTC) #4
kzar
Aug. 21, 2017, 12:53 p.m. (2017-08-21 12:53:22 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld