Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: options.js

Issue 29522601: Noissue - Use includes instead of indexOf (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Aug. 21, 2017, 11:16 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/notificationHelper.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 644 matching lines...) Expand 10 before | Expand all | Expand 10 after
655 removeButton.addEventListener("click", () => 655 removeButton.addEventListener("click", () =>
656 { 656 {
657 if (!confirm(i18n.getMessage("global_remove_subscription_warning"))) 657 if (!confirm(i18n.getMessage("global_remove_subscription_warning")))
658 return; 658 return;
659 659
660 removeSubscription(subscription.url); 660 removeSubscription(subscription.url);
661 }, false); 661 }, false);
662 662
663 getPref("additional_subscriptions", additionalSubscriptions => 663 getPref("additional_subscriptions", additionalSubscriptions =>
664 { 664 {
665 if (additionalSubscriptions.indexOf(subscription.url) != -1) 665 if (additionalSubscriptions.includes(subscription.url))
666 removeButton.style.visibility = "hidden"; 666 removeButton.style.visibility = "hidden";
667 }); 667 });
668 668
669 let enabled = element.getElementsByClassName("subscriptionEnabled")[0]; 669 let enabled = element.getElementsByClassName("subscriptionEnabled")[0];
670 enabled.addEventListener("click", () => 670 enabled.addEventListener("click", () =>
671 { 671 {
672 subscription.disabled = !subscription.disabled; 672 subscription.disabled = !subscription.disabled;
673 toggleSubscription(subscription.url, true); 673 toggleSubscription(subscription.url, true);
674 }, false); 674 }, false);
675 675
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 onFilterMessage(message.action, message.args[0]); 735 onFilterMessage(message.action, message.args[0]);
736 break; 736 break;
737 case "prefs.respond": 737 case "prefs.respond":
738 onPrefMessage(message.action, message.args[0]); 738 onPrefMessage(message.action, message.args[0]);
739 break; 739 break;
740 case "subscriptions.respond": 740 case "subscriptions.respond":
741 onSubscriptionMessage(message.action, message.args[0]); 741 onSubscriptionMessage(message.action, message.args[0]);
742 break; 742 break;
743 } 743 }
744 }); 744 });
OLDNEW
« no previous file with comments | « lib/notificationHelper.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld