Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/requestBlocker.js

Issue 29522656: Issue 5316 - Adds supported filter types export value to requestBlocker (Closed)
Patch Set: Created Sept. 5, 2017, 5:24 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/requestBlocker.js
===================================================================
--- a/lib/requestBlocker.js
+++ b/lib/requestBlocker.js
@@ -48,16 +48,28 @@
// Treat navigator.sendBeacon() the same as <a ping>, it's essentially the
// same concept - merely generalized.
yield ["beacon", "PING"];
// Treat <img srcset> and <picture> the same as other images.
yield ["imageset", "IMAGE"];
}());
+exports.filterTypes = new Set(function*()
+{
+ if (!(chrome.webRequest.ResourceType))
Sebastian Noack 2017/09/05 18:08:10 Please add a comment like this: "Microsoft Edge d
Jon Sonesen 2017/09/06 12:55:43 Acknowledged.
+ return;
+ for (let type in chrome.webRequest.ResourceType)
+ yield resourceTypes.get(chrome.webRequest.ResourceType[type]) || "OTHER";
+ yield "WEBSOCKET";
Sebastian Noack 2017/09/05 18:08:11 Please add a comment like this: "WEBSOCKET and WE
Jon Sonesen 2017/09/06 12:55:43 Acknowledged.
+ yield "WEBRTC";
+ yield "POPUP";
Sebastian Noack 2017/09/05 18:08:10 Please add a comment like this: "POPUP and ELEMHI
Jon Sonesen 2017/09/06 12:55:43 Acknowledged.
+ yield "ELEMHIDE";
+}());
+
function onBeforeRequestAsync(page, url, type, docDomain,
thirdParty, sitekey,
specificOnly, filter)
{
if (filter)
FilterNotifier.emit("filter.hitCount", filter, 0, 0, page);
if (devtools)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld