Issue 5552 - use strict mode for all JS in libadblocklus

src/JsEngine.cpp

Index: src/JsEngine.cpp
diff --git a/src/JsEngine.cpp b/src/JsEngine.cpp
index eb497a675d63d27be000d5f86a01eeaf7b3eeae9..475353bb4ea6e38f6db3875815f604dbefc6143c 100644
--- a/src/JsEngine.cpp
+++ b/src/JsEngine.cpp
@@ -52,6 +52,8 @@ namespace
     {
       v8::V8::InitializePlatform(platform);
       v8::V8::Initialize();

[anton, 2017/08/22 08:22:33]

in v8_initiliazer.cc in chromium `v8::V8::Initialize();` is invoked after flags
set:
  v8::V8::InitializePlatform(vp);

  ...
  if (IsolateHolder::kStrictMode == mode) {
    static const char use_strict[] = "--use_strict";
    v8::V8::SetFlagsFromString(use_strict, sizeof(use_strict) - 1);
  }
  ...
  v8::V8::Initialize();

did/can you make sure the order you've used is not important here?

[sergei, 2017/08/22 10:52:18]

Good catch! Actually this particular flag is used only when a compilation of a
script is called, namely for us it's when JsEngine::Evaluate is called, so the
current order is fine. Actually I have taken the order from
https://github.com/v8/v8/blob/master/src/d8.cc. However, in both d8.cc (call of
Shell::SetOptions) and in the code of v8 I see that some flags should be set
before v8::V8::Initialize();. So, to simplify the catching of potential bugs
when we decide to add new flags I have moved setting of the flags even before
creation of a platform, as it's done in d8.cc.

+      std::string cmd = "--use_strict";
+      v8::V8::SetFlagsFromString(cmd.c_str(), cmd.length());
     }
 
     ~V8Initializer()