test/JsEngine.cpp - Issue 29523555: Issue 5552 - use strict mode for all JS in libadblocklus

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: test/JsEngine.cpp

Issue 29523555: Issue 5552 - use strict mode for all JS in libadblocklus (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git

Patch Set: move setting of V8 flags at the very beginning Created Aug. 22, 2017, 10:51 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/JsEngine.cpp

diff --git a/test/JsEngine.cpp b/test/JsEngine.cpp

index 207316da60d2cd6f4a0ff8c768590f8660ee0b76..838f29e6325d65f58770030986b0582b9cffa55a 100644

--- a/test/JsEngine.cpp

+++ b/test/JsEngine.cpp

@@ -70,7 +70,7 @@ namespace {

AdblockPlus::JsValueList params;

params.push_back(v1);

params.push_back(v2);

- return jsEngine.Evaluate("f = function(a, b) { return a == b };").Call(params).AsBool();

+ return jsEngine.Evaluate("(function(a, b) { return a == b })").Call(params).AsBool();

}

« no previous file with comments | « test/GlobalJsObject.cpp ('k') | test/WebRequest.cpp » ('j') | no next file with comments »