Issue 29523682: Issue 5556 - use FilterEngine& instead of FilterEnginePtr because FilterEnginePtr is not available

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29523682: Issue 5556 - use FilterEngine& instead of FilterEnginePtr because FilterEnginePtr is not available (Closed)

Created:
Aug. 22, 2017, 2:40 p.m. by sergei

Modified:
Aug. 25, 2017, 7:33 a.m.

Reviewers:
anton, diegocarloslima, jens

CC:
Felix Dahlke, René Jeschke

Base URL:
github.com:abby-sergz/libadblockplus-android.git

Visibility:
Public.

anymore # It's a small self-contained step in order to accomplish #5556.

Created: Aug. 22, 2017, 2:40 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -64 lines)			Patch
	M	libadblockplus-android/jni/JniFilterEngine.cpp	View		27 chunks	+59 lines, -64 lines	0 comments	Download

Total messages: 4

anton

On 2017/08/22 14:42:34, sergei wrote: LGTM (also checked to be compilable)

Aug. 23, 2017, 6:46 a.m. (2017-08-23 06:46:42 UTC) #2

diegocarloslima

On 2017/08/23 06:46:42, anton wrote: > On 2017/08/22 14:42:34, sergei wrote: > > LGTM (also ...

Aug. 24, 2017, 11:44 a.m. (2017-08-24 11:44:24 UTC) #3

anton

Aug. 25, 2017, 5:48 a.m. (2017-08-25 05:48:12 UTC) #4

On 2017/08/23 06:46:42, anton wrote:
> On 2017/08/22 14:42:34, sergei wrote:
> 
> LGTM (also checked to be compilable)

Pushed