Issue 3916 - Supporting Adding filter lists via URL

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 185 matching lines @@
       {
         // This is a temporary fix to not write filters that might crash Samsung Internet
         // See https://issues.adblockplus.org/ticket/4772
         if (!filter.matches(UNSUPPORTED_FILTERS_REGEX))
         {
           w.write(filter);
           w.write('\n');
         }
         else
         {
+          w.write(filter);
+          w.write('\n');

[diegocarloslima, 2017/09/22 17:43:43]

We shouldn't revert this temporary fix in this ticket. Also, we need first to
align with Samsung if almost no users are still using an old version of the
browser that doesn't contain the edge case crash fix.

[jens, 2017/09/26 10:25:02]

Sorry, I don't know how these two lines slipped into the patch set. That was
definitely not on purpose!

           Log.d(TAG, "Ignoring unsupported filter: " + filter);
         }
       }
     }
   }
 
   public Subscription add(final Subscription sub)
   {
     final String id = sub.getId();
     if (!this.subscriptions.containsKey(id))
     {
       this.subscriptions.put(id, sub);
       return sub;
     }
     return this.subscriptions.get(id);
   }
 
+  public boolean remove(final String id)
+  {
+    return this.subscriptions.remove(id) != null;
+  }
+
   public static Subscriptions initialize(final Engine engine, final File appFolder,
       final File cacheFolder)
   {
     final Subscriptions subs = new Subscriptions(engine, appFolder, cacheFolder);
 
     subs.subscriptionFolder.mkdirs();
     subs.cacheFolder.mkdirs();
 
     final File[] files = subs.subscriptionFolder.listFiles();
     for (File f : files)
@@ skipping 51 matching lines @@
     if (sub != null)
     {
       if (sub.updateSubscription(responseCode, text, httpHeaders, this.getMetaFile(sub),
           this.getFiltersFile(sub)))
       {
         this.engine.requestUpdateBroadcast();
       }
     }
   }
 }