Issue 3916 - Supporting Adding filter lists via URL

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Subscriptions.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 204 matching lines @@
     if (!this.subscriptions.containsKey(id))
     {
       this.subscriptions.put(id, sub);
       return sub;
     }
     return this.subscriptions.get(id);
   }
 
   public boolean remove(final String id)
   {
-    if (this.subscriptions.containsKey(id))

[anton, 2017/08/25 10:40:40]

the whole method could be replaced with `return this.subscriptions.remove(id) !=
null;`, is it?
BTW is return value needed somewhere?

[jens, 2017/08/25 11:35:07]

Acknowledged.
The return values is not needed yet but I thought it makes sense to confirm if
the subscription was removed or not.

-    {
-      this.subscriptions.remove(id);
-      return true;
-    }
-    return false;
+    return this.subscriptions.remove(id) != null;
   }
 
   public static Subscriptions initialize(final Engine engine, final File appFolder,
       final File cacheFolder)
   {
     final Subscriptions subs = new Subscriptions(engine, appFolder, cacheFolder);
 
     subs.subscriptionFolder.mkdirs();
     subs.cacheFolder.mkdirs();
 
@@ skipping 53 matching lines @@
     if (sub != null)
     {
       if (sub.updateSubscription(responseCode, text, httpHeaders, this.getMetaFile(sub),
           this.getFiltersFile(sub)))
       {
         this.engine.requestUpdateBroadcast();
       }
     }
   }
 }