Issue 3916 - Supporting Adding filter lists via URL

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/InputValidatorDialogPreference.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 18 matching lines @@
 import android.util.Log;
 import android.util.Patterns;
 import android.view.KeyEvent;
 import android.view.View;
 import android.view.inputmethod.EditorInfo;
 import android.widget.EditText;
 import android.widget.TextView;
 import android.widget.Toast;
 
 import org.adblockplus.adblockplussbrowser.R;
+import org.adblockplus.sbrowser.contentblocker.engine.Engine;
 import org.adblockplus.sbrowser.contentblocker.util.PreferenceUtils;
 import org.apache.commons.validator.routines.DomainValidator;
 
 public class InputValidatorDialogPreference extends EditTextPreference implements TextWatcher,
     TextView.OnEditorActionListener
 {
 
   public enum ValidationType
   {
     DOMAIN,
     URL
   }
 
+  private static final String TAG = InputValidatorDialogPreference.class.getSimpleName();
   private OnInputReadyListener onInputReadyListener;
   private AlertDialog alertDialog;
   private ValidationType validationType;
 
   public InputValidatorDialogPreference(Context context)
   {
     this(context, null);
   }
 
   public InputValidatorDialogPreference(Context context, AttributeSet attrs)
@@ skipping 92 matching lines @@
 
   private boolean isValidUrl()
   {
     return Patterns.WEB_URL.matcher(getInput()).matches();
   }
 
   private boolean isValidInput()
   {
     if (validationType == null)
     {
-      Log.i(getClass().getSimpleName(), "ValidationType was not defined and is therefore set to" +

[diegocarloslima, 2017/10/10 13:08:28]

I know that the log tag is currently only used here, but it is a good practice
to define it globally (private static final String TAG = ...) so if we ever use
it in multiple places, we would have a consistent TAG field that can be changed
when needed (e.g. to a hardcoded string to avoid obfuscation or to avoid the tag
limit of 23 chars)

[jens, 2017/10/10 13:56:40]

I was not sure if it's mandatory, as there are also classes that don't use a log
tag. But I'll add it here.

+      Log.i(TAG, "ValidationType was not defined and is therefore set to" +
           " ValidationType.URL per default. Please consider to set in manually.");
       validationType = ValidationType.URL;
     }
 
     switch (validationType)
     {
       case DOMAIN:
         return isValidDomain();
       default:
         return isValidUrl();
@@ skipping 11 matching lines @@
     {
       alertDialog.getButton(AlertDialog.BUTTON_POSITIVE).setEnabled(enabled);
     }
   }
 
   public interface OnInputReadyListener
   {
     void onInputReady(String input);
   }
 }