Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29524903: Noissue - Add helper script to import changes from Rietveld reviews (Closed)

Created:
Aug. 23, 2017, 2:50 p.m. by Vasily Kuznetsov
Modified:
Aug. 28, 2017, 3:30 p.m.
CC:
Jon Sonesen
Visibility:
Public.

Description

This is a script that I use for local testing of the changes from reviews. Thought it could be useful for others too. Repository: https://hg.adblockplus.org/codingtools Base revision: 9eec8dfdcbcb

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address comment 4 #

Total comments: 4

Patch Set 3 : Make rapply.sh commit the changes and work without installing patchconv.py #

Total comments: 6

Patch Set 4 : Revert the committing logic and simplify patchconv discovery #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M patchconv/README.md View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A patchconv/rapply.sh View 1 2 3 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 15
Vasily Kuznetsov
Hi! Here's a script that I'm using for applying changes from Rietveld reviews to my ...
Aug. 23, 2017, 2:57 p.m. (2017-08-23 14:57:36 UTC) #1
kzar
Cool idea but wouldn't it make sense to just put the patch fixing logic in ...
Aug. 23, 2017, 3:04 p.m. (2017-08-23 15:04:23 UTC) #2
Vasily Kuznetsov
On 2017/08/23 15:04:23, kzar wrote: > Cool idea but wouldn't it make sense to just ...
Aug. 23, 2017, 3:16 p.m. (2017-08-23 15:16:14 UTC) #3
Sebastian Noack
On 2017/08/23 15:16:14, Vasily Kuznetsov wrote: > On 2017/08/23 15:04:23, kzar wrote: > > Cool ...
Aug. 23, 2017, 3:52 p.m. (2017-08-23 15:52:33 UTC) #4
Vasily Kuznetsov
Thanks for the comments, Sebastian, here's a new improved version. https://codereview.adblockplus.org/29524903/diff/29524904/patchconv/rapply.sh File patchconv/rapply.sh (right): https://codereview.adblockplus.org/29524903/diff/29524904/patchconv/rapply.sh#newcode1 ...
Aug. 23, 2017, 4:29 p.m. (2017-08-23 16:29:39 UTC) #5
Sebastian Noack
LGTM
Aug. 23, 2017, 5:21 p.m. (2017-08-23 17:21:40 UTC) #6
juliandoucette
https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh File patchconv/rapply.sh (right): https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh#newcode28 patchconv/rapply.sh:28: IMPORT="hg import --no-commit -" There is no --no-commit option ...
Aug. 25, 2017, 12:07 p.m. (2017-08-25 12:07:12 UTC) #7
Sebastian Noack
https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh File patchconv/rapply.sh (right): https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh#newcode28 patchconv/rapply.sh:28: IMPORT="hg import --no-commit -" On 2017/08/25 12:07:12, juliandoucette wrote: ...
Aug. 25, 2017, 12:12 p.m. (2017-08-25 12:12:18 UTC) #8
juliandoucette
https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh File patchconv/rapply.sh (right): https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh#newcode28 patchconv/rapply.sh:28: IMPORT="hg import --no-commit -" On 2017/08/25 12:12:18, Sebastian Noack ...
Aug. 25, 2017, 12:21 p.m. (2017-08-25 12:21:28 UTC) #9
Vasily Kuznetsov
On 2017/08/25 12:21:28, juliandoucette wrote: > https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh > File patchconv/rapply.sh (right): > > https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh#newcode28 > ...
Aug. 25, 2017, 1:44 p.m. (2017-08-25 13:44:52 UTC) #10
Sebastian Noack
https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh File patchconv/rapply.sh (right): https://codereview.adblockplus.org/29524903/diff/29524910/patchconv/rapply.sh#newcode28 patchconv/rapply.sh:28: IMPORT="hg import --no-commit -" On 2017/08/25 13:44:52, Vasily Kuznetsov ...
Aug. 25, 2017, 1:49 p.m. (2017-08-25 13:49:54 UTC) #11
Vasily Kuznetsov
Here we go. The current version always commits the patch and can use the `patchconv.py` ...
Aug. 25, 2017, 3:49 p.m. (2017-08-25 15:49:11 UTC) #12
Sebastian Noack
https://codereview.adblockplus.org/29524903/diff/29527782/patchconv/rapply.sh File patchconv/rapply.sh (right): https://codereview.adblockplus.org/29524903/diff/29527782/patchconv/rapply.sh#newcode27 patchconv/rapply.sh:27: alias IMPORT="git apply --index && git commit -m '$MESSAGE'" ...
Aug. 25, 2017, 4:40 p.m. (2017-08-25 16:40:39 UTC) #13
Vasily Kuznetsov
Hi Sebastian, I made it not commit again (sorry, Julian, you will need to fix ...
Aug. 25, 2017, 6:52 p.m. (2017-08-25 18:52:15 UTC) #14
Sebastian Noack
Aug. 25, 2017, 8:06 p.m. (2017-08-25 20:06:15 UTC) #15
LGTM

Powered by Google App Engine
This is Rietveld