metadata.chrome - Issue 29526555: Issue 5554 - [webextensions] Adjust data to account for UI limitations

Side by Side Diff: metadata.chrome

Issue 29526555: Issue 5554 - [webextensions] Adjust data to account for UI limitations (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome

Patch Set: Created Aug. 24, 2017, 9:02 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [general]	1 [general]

2 basename = adblockpluschrome	2 basename = adblockpluschrome

3 version = 1.13.3	3 version = 1.13.3

4 author = eyeo GmbH	4 author = eyeo GmbH

5 permissions = tabs	5 permissions = tabs

6 <all_urls>	6 <all_urls>

7 contextMenus	7 contextMenus

8 webRequest	8 webRequest

9 webRequestBlocking	9 webRequestBlocking

10 webNavigation	10 webNavigation

(...skipping 94 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
105 adblockpluscore/lib/jsbn.js	105 adblockpluscore/lib/jsbn.js

106 adblockpluscore/lib/matcher.js	106 adblockpluscore/lib/matcher.js

107 adblockpluscore/lib/notification.js	107 adblockpluscore/lib/notification.js

108 adblockpluscore/lib/rsa.js	108 adblockpluscore/lib/rsa.js

109 adblockpluscore/lib/rusha.js	109 adblockpluscore/lib/rusha.js

110 adblockpluscore/lib/subscriptionClasses.js	110 adblockpluscore/lib/subscriptionClasses.js

111 adblockpluscore/lib/synchronizer.js	111 adblockpluscore/lib/synchronizer.js

112 adblockplusui/lib/antiadblockInit.js	112 adblockplusui/lib/antiadblockInit.js

113 lib/adblockplus.js[module] = true	113 lib/adblockplus.js[module] = true

114 lib/adblockplus.js[injectinfomodule] = true	114 lib/adblockplus.js[injectinfomodule] = true

115 lib/adblockplus.js[autoload] = filterListener,synchronizer,requestBlocker,popupB locker,subscriptionInit,filterComposer,stats,uninstall,csp,cssInjection	115 lib/adblockplus.js[autoload] = filterListener,synchronizer,requestBlocker,popupB locker,subscriptionInit,filterComposer,stats,uninstall,csp,cssInjection,firefoxD ataCleanup
	Wladimir Palant 2017/08/24 09:08:09 This should really be added in metadata.gecko-webe This should really be added in metadata.gecko-webext but that doesn't work correctly. IMHO, the format has been misdesigned here, spaces as separator would allow extending the value in configurations inheriting from this one. Sebastian Noack 2017/08/24 09:42:05 I agree. But probably not worth changing if we mov Show quoted text On 2017/08/24 09:08:09, Wladimir Palant wrote: > This should really be added in metadata.gecko-webext but that doesn't work > correctly. IMHO, the format has been misdesigned here, spaces as separator would > allow extending the value in configurations inheriting from this one. I agree. But probably not worth changing if we move to webpack soon anyway? Wladimir Palant 2017/08/24 09:57:43 Rather something to be changed in the same go. We' Show quoted text On 2017/08/24 09:42:05, Sebastian Noack wrote: > I agree. But probably not worth changing if we move to webpack soon anyway? Rather something to be changed in the same go. We'll need to specify entry points for webpack as well, we should make sure that these are separated by spaces. Sebastian Noack 2017/08/24 10:19:44 Acknowledged. Show quoted text On 2017/08/24 09:57:43, Wladimir Palant wrote: > On 2017/08/24 09:42:05, Sebastian Noack wrote: > > I agree. But probably not worth changing if we move to webpack soon anyway? > > Rather something to be changed in the same go. We'll need to specify entry > points for webpack as well, we should make sure that these are separated by > spaces. Acknowledged. kzar 2017/08/29 11:33:48 Noted, I'll do that. Show quoted text On 2017/08/24 10:19:44, Sebastian Noack wrote: > On 2017/08/24 09:57:43, Wladimir Palant wrote: > > On 2017/08/24 09:42:05, Sebastian Noack wrote: > > > I agree. But probably not worth changing if we move to webpack soon anyway? > > > > Rather something to be changed in the same go. We'll need to specify entry > > points for webpack as well, we should make sure that these are separated by > > spaces. > > Acknowledged. Noted, I'll do that.
116 include.preload.js = include.preload.js inject.preload.js	116 include.preload.js = include.preload.js inject.preload.js

117 include.postload.js = subscriptionLink.postload.js composer.postload.js	117 include.postload.js = subscriptionLink.postload.js composer.postload.js

118 elemHideEmulation.js = adblockpluscore/lib/common.js adblockpluscore/chrome/cont ent/elemHideEmulation.js	118 elemHideEmulation.js = adblockpluscore/lib/common.js adblockpluscore/chrome/cont ent/elemHideEmulation.js

119	119

120 [import_locales]	120 [import_locales]

121 adblockplus/chrome/locale/*/global.properties = subscription_invalid_location	121 adblockplus/chrome/locale/*/global.properties = subscription_invalid_location

122 remove_subscription_warning	122 remove_subscription_warning

123 =notification_antiadblock_title	123 =notification_antiadblock_title

124 =notification_antiadblock_message	124 =notification_antiadblock_message

125 filter_unknown_option	125 filter_unknown_option

(...skipping 17 matching lines...) Expand all Loading...
143 addSubscription.label	143 addSubscription.label

144 addSubscriptionAdd.label	144 addSubscriptionAdd.label

145 addSubscriptionOther.label	145 addSubscriptionOther.label

146 acceptableAds2.label	146 acceptableAds2.label

147 viewList.label	147 viewList.label

148 readMore.label	148 readMore.label

149 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	149 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

150 title.label	150 title.label

151 adblockplus/chrome/locale/*/meta.properties = =name	151 adblockplus/chrome/locale/*/meta.properties = =name

152 adblockplusui/locale//firstRun.json = =	152 adblockplusui/locale//firstRun.json = =

OLD	NEW

« lib/prefs.js ('K') | « lib/prefs.js ('k') | metadata.gecko-webext » ('j') | no next file with comments »