Issue 5554 - [webextensions] Adjust data to account for UI limitations

lib/prefs.js

Index: lib/prefs.js
===================================================================
--- a/lib/prefs.js
+++ b/lib/prefs.js
@@ -46,17 +46,17 @@ defaults.currentVersion = "";
  *
  * @type {string}
  */
 defaults.data_directory = "";
 /**
  * @see https://adblockplus.org/en/preferences#patternsbackups
  * @type {number}
  */
-defaults.patternsbackups = 5;
+defaults.patternsbackups = 0;

[Wladimir Palant, 2017/08/24 09:08:09]

I don't know why this feature was enabled initially, it's useless right now. On
Firefox it also degrades performance considerably because both patterns.ini and
all the backups are stored in a single JSON file.

 /**
  * @see https://adblockplus.org/en/preferences#patternsbackupinterval
  * @type {number}
  */
 defaults.patternsbackupinterval = 24;
 /**
  * Only for compatibility with core code. Please do not change!
  *
@@ -143,16 +143,24 @@ defaults.hidePlaceholders = true;
 
 /**
  * Whether notification opt-out UI should be shown.
  * @type {boolean}
  */
 defaults.notifications_showui = false;
 
 /**
+ * Determines whether data has been cleaned up after upgrading from the legacy
+ * extension on Firefox.
+ *
+ * @type {boolean}
+ */
+defaults.data_cleanup_done = false;

[Sebastian Noack, 2017/08/24 09:42:05]

This way the data migration will also be performed on fresh installation. I
wonder whether it would be worth to prevent that.

[Wladimir Palant, 2017/08/24 09:57:43]

On a fresh install this will be a fast operation. Then again, we can detect
first run easily.

+
+/**
  * Notification categories to be ignored.
  *
  * @type {string[]}
  */
 defaults.notifications_ignoredcategories = [];
 
 /**
  * Whether to show the developer tools panel.