Issue 5559 - include Node.js in ensure_dependencies.py

ensure_dependencies.py

 #!/usr/bin/env python
 
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import sys
 import os
 import posixpath
 import re
@@ skipping 245 matching lines @@
     Additionally, make sure that any VCS will ignore the installed files.
 
     Requires Node.js to be installed locally.
     """
     try:
         with open(os.path.join(target, 'package.json'), 'r') as fp:
             package_data = json.load(fp)
 
         # In case a package.json does not exist at all or if there are no
         # production dependencies declared, we don't need to run npm and can
-        # bail out early

[Vasily Kuznetsov, 2017/08/25 18:37:40]

Nit: please add periods to the comments that are complete sentences. PEP8[1]
suggests this.

[1] https://www.python.org/dev/peps/pep-0008/#comments

[tlucas, 2017/08/28 06:53:16]

Done.

+        # bail out early.
         if not package_data.get('dependencies', False):
             return
     except IOError:
         return
 
     try:
         cmd = ['npm', 'install', '--only=production', '--loglevel=warn']
         subprocess.check_output(cmd, cwd=target)
 
-        # Make sure Node.js related files / folders are ignored by the VCS in

[Vasily Kuznetsov, 2017/08/25 18:37:40]

It seems that this comment is redundant given that we've documented the behavior
in the docstring and `repo_types[vcs].ignore(...)` seems pretty
self-explanatory.

[tlucas, 2017/08/28 06:53:16]

Done.

-        # use
-        repo_types[vcs].ignore(

[Vasily Kuznetsov, 2017/08/25 18:37:40]

Wouldn't this be more readable as one line?

[tlucas, 2017/08/28 06:53:16]

Done.

-            os.path.join(target, 'node_modules'), target
-        )
+        repo_types[vcs].ignore(os.path.join(target, 'node_modules'), target)
     except OSError as e:
         import errno
         if e.errno == errno.ENOENT:
             logging.error('Failed to install Node.js dependencies for %s,'
                           ' please ensure Node.js is installed.', target)
         else:
             raise
 
 
 def ensure_repo(parentrepo, parenttype, target, type, root, sourcename):
@@ skipping 128 matching lines @@
     args = parser.parse_args()
 
     if args.quiet:
         logging.disable(logging.INFO)
 
     repos = args.repos
     if not len(repos):
         repos = [os.path.dirname(__file__)]
     for repo in repos:
         resolve_deps(repo)