Issue 5566 - Move 'Get Whitelisted' page out of 'Solutions'

Issue 5566 - Move 'Get Whitelisted' page out of 'Solutions'

COLLABORATOR=i.aderinokun@eyeo.com

[juliandoucette, 2017-08-24 15:21:47]

Ready for review.

- This patchset may be missing the removal of pages/solutions/get-whitelisted/*
(I moved the using hg mv but I don't see that represented on reitveld)
- This form is critical enough to warrent review and testing

[ire, 2017-08-25 10:36:18]

On 2017/08/24 15:21:47, juliandoucette wrote:
> Ready for review.
> 
> - This patchset may be missing the removal of
pages/solutions/get-whitelisted/*
> (I moved the using hg mv but I don't see that represented on reitveld)
> - This form is critical enough to warrent review and testing

Noted.

I've having trouble getting this patchset to apply. There seems to be an error
with globals/sitemap.py

There are links to the "Get Whitelisted" page that are still using the old URL:

- The "Who Benefits?" section on the homepage
- /solutions/publishers, /solutions/ad-networks, etc.

(There may be more I didn't find)

[juliandoucette, 2017-08-25 12:10:54]

Note: I may not get to this for a little while (I have to go to see the doctor
today). You are welcome to submit your own Patchset in order to get this into
testing sooner. I will add you as a collaborator.

On 2017/08/25 10:36:18, ire wrote:
> I've having trouble getting this patchset to apply. There seems to be an error
> with globals/sitemap.py

Yes. Merge conflict with -r 251. Sorry. I will fix and rebase ASAP.

> There are links to the "Get Whitelisted" page that are still using the old
URL:
> 
> - The "Who Benefits?" section on the homepage
> - /solutions/publishers, /solutions/ad-networks, etc.
> 
> (There may be more I didn't find)

Good catch. I thought that I searched for these :/.

[ire, 2017-08-25 14:55:22]

On 2017/08/25 12:10:54, juliandoucette wrote:
> Note: I may not get to this for a little while (I have to go to see the doctor
> today). You are welcome to submit your own Patchset in order to get this into
> testing sooner. I will add you as a collaborator.
> 
> On 2017/08/25 10:36:18, ire wrote:
> > I've having trouble getting this patchset to apply. There seems to be an
error
> > with globals/sitemap.py
> 
> Yes. Merge conflict with -r 251. Sorry. I will fix and rebase ASAP.
> 
> > There are links to the "Get Whitelisted" page that are still using the old
> URL:
> > 
> > - The "Who Benefits?" section on the homepage
> > - /solutions/publishers, /solutions/ad-networks, etc.
> > 
> > (There may be more I didn't find)
> 
> Good catch. I thought that I searched for these :/.

No worries :) I've uploaded a patch.

[juliandoucette, 2017-08-25 15:46:25]

> No worries :) I've uploaded a patch.

Thanks Ire!

LGTM with one NIT -> You didn't fix
[this](https://issues.adblockplus.org/ticket/5379) issue in the updated links.
This isn't a problem yet because we have not translated acceptableads.com.
Before we translate this website, we must change all of these URLs so that all
paths resolve to the currently selected language instead of the one decided by
HTTP headers.

@Robert, @Vasily

We have moved the Get Whitelisted form in this Patchset. I don't think that this
will break anything. But I don't know for sure. Can you please confirm Vasily
and/or Robert?

[Vasily Kuznetsov, 2017-08-25 18:58:34]

On 2017/08/25 15:46:25, juliandoucette wrote:
> > No worries :) I've uploaded a patch.
> 
> Thanks Ire!
> 
> LGTM with one NIT -> You didn't fix
> [this](https://issues.adblockplus.org/ticket/5379) issue in the updated links.
> This isn't a problem yet because we have not translated
http://acceptableads.com.
> Before we translate this website, we must change all of these URLs so that all
> paths resolve to the currently selected language instead of the one decided by
> HTTP headers.
> 
> @Robert, @Vasily
> 
> We have moved the Get Whitelisted form in this Patchset. I don't think that
this
> will break anything. But I don't know for sure. Can you please confirm Vasily
> and/or Robert?

Hi Julian,

It looks like the form is submitted to
"https://eyeo.sugarondemand.com/index.php?entryPoint=WebToLeadCapture", which I
suppose is SugarCRM. The URL hasn't changed, so hopefully it should still work.
I can't be completely sure though, I guess you need to ask the person who
configured this entry point.

Cheers,
Vasily

[ire, 2017-08-28 09:15:33]

On 2017/08/25 15:46:25, juliandoucette wrote:
> > No worries :) I've uploaded a patch.
> 
> Thanks Ire!
> 
> LGTM with one NIT -> You didn't fix
> [this](https://issues.adblockplus.org/ticket/5379) issue in the updated links.
> This isn't a problem yet because we have not translated
http://acceptableads.com.
> Before we translate this website, we must change all of these URLs so that all
> paths resolve to the currently selected language instead of the one decided by
> HTTP headers.

You're welcome :)

Noted about issue 5379. I think it makes sense to update all the URLs in that
issue as well.
You're free to push this whenever you're ready (LGTM)