Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23)

Issue 29526635: Issue 5566 - Move 'Get Whitelisted' page out of 'Solutions' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by juliandoucette
Modified:
2 years, 2 months ago
Reviewers:
Vasily Kuznetsov, ire
CC:
saroyanm, Robert Raceanu
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Issue 5566 - Move 'Get Whitelisted' page out of 'Solutions' COLLABORATOR=i.aderinokun@eyeo.com

Patch Set 1 #

Patch Set 2 : Rebase and update urls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -309 lines) Patch
M globals/sitemap.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M includes/index/who-benefits/ad-networks.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/index/who-benefits/ad-tech-suppliers.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/index/who-benefits/advertisers.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/index/who-benefits/publishers.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/index/who-benefits/users.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/solutions/ad-networks.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/solutions/ad-tech-suppliers.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/solutions/advertisers.md View 1 1 chunk +1 line, -1 line 0 comments Download
M includes/solutions/publishers.md View 1 1 chunk +1 line, -1 line 0 comments Download
A pages/get-whitelisted/index.md View 1 1 chunk +285 lines, -0 lines 0 comments Download
A pages/get-whitelisted/thank-you.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
M pages/solutions/ad-networks.md View 1 1 chunk +1 line, -1 line 0 comments Download
M pages/solutions/ad-tech-suppliers.md View 1 1 chunk +1 line, -1 line 0 comments Download
M pages/solutions/advertisers.md View 1 1 chunk +1 line, -1 line 0 comments Download
R pages/solutions/get-whitelisted/index.md View 1 1 chunk +0 lines, -286 lines 0 comments Download
R pages/solutions/get-whitelisted/thank-you.md View 1 1 chunk +0 lines, -8 lines 0 comments Download
M pages/solutions/publishers.md View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
juliandoucette
2 years, 2 months ago (2017-08-24 15:19:49 UTC) #1
juliandoucette
Ready for review. - This patchset may be missing the removal of pages/solutions/get-whitelisted/* (I moved ...
2 years, 2 months ago (2017-08-24 15:21:47 UTC) #2
ire
On 2017/08/24 15:21:47, juliandoucette wrote: > Ready for review. > > - This patchset may ...
2 years, 2 months ago (2017-08-25 10:36:18 UTC) #3
juliandoucette
Note: I may not get to this for a little while (I have to go ...
2 years, 2 months ago (2017-08-25 12:10:54 UTC) #4
ire
On 2017/08/25 12:10:54, juliandoucette wrote: > Note: I may not get to this for a ...
2 years, 2 months ago (2017-08-25 14:55:22 UTC) #5
juliandoucette
> No worries :) I've uploaded a patch. Thanks Ire! LGTM with one NIT -> ...
2 years, 2 months ago (2017-08-25 15:46:25 UTC) #6
Vasily Kuznetsov
On 2017/08/25 15:46:25, juliandoucette wrote: > > No worries :) I've uploaded a patch. > ...
2 years, 2 months ago (2017-08-25 18:58:34 UTC) #7
ire
2 years, 2 months ago (2017-08-28 09:15:33 UTC) #8
On 2017/08/25 15:46:25, juliandoucette wrote:
> > No worries :) I've uploaded a patch.
> 
> Thanks Ire!
> 
> LGTM with one NIT -> You didn't fix
> [this](https://issues.adblockplus.org/ticket/5379) issue in the updated links.
> This isn't a problem yet because we have not translated
http://acceptableads.com.
> Before we translate this website, we must change all of these URLs so that all
> paths resolve to the currently selected language instead of the one decided by
> HTTP headers.

You're welcome :)

Noted about issue 5379. I think it makes sense to update all the URLs in that
issue as well.
You're free to push this whenever you're ready (LGTM)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5