Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29527610: Noissue - Add version check for runtime.openOptionsPage for Firefox for Android (Closed)

Created:
Aug. 25, 2017, 9:19 a.m. by Manish Jethani
Modified:
Aug. 25, 2017, 11:32 a.m.
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Noissue - Add version check for runtime.openOptionsPage for Firefox for Android

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update comment #

Total comments: 2

Patch Set 3 : Remove check for 57.0a1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M ext/background.js View 1 2 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7
Manish Jethani
Aug. 25, 2017, 9:19 a.m. (2017-08-25 09:19:09 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29527610/diff/29527611/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29527610/diff/29527611/ext/background.js#newcode710 ext/background.js:710: info.applicationVersion != "57.0a1"))) This extra check ...
Aug. 25, 2017, 9:20 a.m. (2017-08-25 09:20:53 UTC) #2
Manish Jethani
Patch Set 2: Update comment
Aug. 25, 2017, 9:31 a.m. (2017-08-25 09:31:48 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29527610/diff/29527613/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29527610/diff/29527613/ext/background.js#newcode710 ext/background.js:710: info.applicationVersion != "57.0a1"))) It should be sufficient to check ...
Aug. 25, 2017, 9:56 a.m. (2017-08-25 09:56:46 UTC) #4
Manish Jethani
Patch Set 3: Remove check for 57.0a1 https://codereview.adblockplus.org/29527610/diff/29527613/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29527610/diff/29527613/ext/background.js#newcode710 ext/background.js:710: info.applicationVersion != ...
Aug. 25, 2017, 11:02 a.m. (2017-08-25 11:02:31 UTC) #5
Wladimir Palant
LGTM
Aug. 25, 2017, 11:04 a.m. (2017-08-25 11:04:06 UTC) #6
Sebastian Noack
Aug. 25, 2017, 11:30 a.m. (2017-08-25 11:30:02 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld