Noissue - Open options.html directly on Firefox for Android

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 729 matching lines @@
       if ("windows" in chrome)
       {
         chrome.windows.getLastFocused(win =>
         {
           let optionsUrl = "options.html";
           let queryInfo = {url: optionsUrl};
 
           // extension pages can't be accessed in incognito windows. In order to
           // correctly mimic the way in which Chrome opens extension options,
           // we have to focus the options page in any other window.
           if (!win.incognito)

[Manish Jethani, 2017/08/25 11:24:38]

No longer checking for win being null

The rest of the open function has been copied here as it is.

             queryInfo.windowId = win.id;
 
           chrome.tabs.query(queryInfo, tabs =>
           {
-            if (tabs && tabs.length > 0)
+            if (tabs.length > 0)
             {
               let tab = tabs[0];
 
               if ("windows" in chrome)
                 chrome.windows.update(tab.windowId, {focused: true});
 
               chrome.tabs.update(tab.id, {active: true});
 
               if (callback)
                 callback(new Page(tab));
@@ skipping 19 matching lines @@
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());