compile - Issue 29527808: Noissue - Use meson to build the C++ code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: compile

Issue 29527808: Noissue - Use meson to build the C++ code (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Left Patch Set: Pin meson version. Deprecate compile Created Dec. 13, 2017, 5:09 p.m.

Right Patch Set: Removed compile. meson > 0.40.0 Created Dec. 15, 2017, 5:37 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #!/usr/bin/env python

2

3 # This file is part of Adblock Plus <https://adblockplus.org/>,

4 # Copyright (C) 2006-present eyeo GmbH

5 #

6 # Adblock Plus is free software: you can redistribute it and/or modify

7 # it under the terms of the GNU General Public License version 3 as

8 # published by the Free Software Foundation.

9 #

10 # Adblock Plus is distributed in the hope that it will be useful,

11 # but WITHOUT ANY WARRANTY; without even the implied warranty of

12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

13 # GNU General Public License for more details.

14 #

15 # You should have received a copy of the GNU General Public License

16 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

17

18

19 print "This script is deprecated.\n"

20 print "Please use meson:"

21 print "\tmeson build"

22 print "then:"

23 print "\tninja -C build"
Wladimir Palant 2017/12/14 10:57:01 Is there a point in having this? It's not like we Is there a point in having this? It's not like we have thousands of people rely on the compile script and we need to switch them over to meson now. Most likely, this change only affects the three of us - and we already know. Just remove this script? hub 2017/12/15 17:44:55 habits. I'll just remove compile. Show quoted text On 2017/12/14 10:57:01, Wladimir Palant wrote: > Is there a point in having this? It's not like we have thousands of people rely > on the compile script and we need to switch them over to meson now. Most likely, > this change only affects the three of us - and we already know. Just remove this > script? habits. I'll just remove compile.
24

25 exit(1)

LEFT	RIGHT