modules/adblockplus/manifests/legacy/filterserver.pp - Issue 29527816: #2762 - Fix provisioning of geoip to filter servers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: modules/adblockplus/manifests/legacy/filterserver.pp

Issue 29527816: #2762 - Fix provisioning of geoip to filter servers (Closed)

Left Patch Set: Created Aug. 25, 2017, 5:51 p.m.

Right Patch Set: For comment 5 Created Aug. 30, 2017, 3:20 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # == Class: adblockplus::legacy::filterserver	1 # == Class: adblockplus::legacy::filterserver

2 #

3 # A class for maintaining legacy filter servers.
mathias 2017/08/29 18:09:00 That comment is pretty much pointless. Please eith That comment is pretty much pointless. Please either omit the entire class comment section here (like the "new" style Puppet of documentation, where them authors start to just write everything into the README) or come up with something more useful, thank you! <3 f.lopez 2017/08/30 01:52:38 Done. Show quoted text On 2017/08/29 18:09:00, mathias wrote: > That comment is pretty much pointless. Please either omit the entire class > comment section here (like the "new" style Puppet of documentation, where them > authors start to just write everything into the README) or come up with > something more useful, thank you! <3 Done.
4 #	2 #

5 # See http://hub.eyeo.com/issues/2762 for more information.	3 # See http://hub.eyeo.com/issues/2762 for more information.

6 #	4 #

7 class adblockplus::legacy::filterserver {	5 class adblockplus::legacy::filterserver {

	6

8 include filterserver	7 include filterserver
mathias 2017/08/29 18:09:00 There's a blank line missing above this one. There's a blank line missing above this one. f.lopez 2017/08/30 01:52:38 Done. Show quoted text On 2017/08/29 18:09:00, mathias wrote: > There's a blank line missing above this one. Done.
9	8

10 # Remove any manually installed geoip-database-contrib	9 package {'geoip-database-contrib':
mathias 2017/08/29 18:09:00 That comment is pointless entirely, it explains th That comment is pointless entirely, it explains the same stuff the code does. How about "Formerly used package foobar conflicts with package baz" or just a linkt to the ticket? f.lopez 2017/08/30 01:52:38 Done. Show quoted text On 2017/08/29 18:09:00, mathias wrote: > That comment is pointless entirely, it explains the same stuff the code does. > How about "Formerly used package foobar conflicts with package baz" or just a > linkt to the ticket? Done.
11 package{'geoip-database-contrib':
mathias 2017/08/29 18:09:00 There's a whitespace character missing after the ` There's a whitespace character missing after the `package` keyword. f.lopez 2017/08/30 01:52:38 Done. Show quoted text On 2017/08/29 18:09:00, mathias wrote: > There's a whitespace character missing after the `package` keyword. Done.
12 ensure => 'purged',	10 ensure => 'purged',

13 }	11 }

14 }	12 }

15	13

LEFT	RIGHT