modules/adblockplus/manifests/legacy/filterserver.pp - Issue 29527816: #2762 - Fix provisioning of geoip to filter servers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: modules/adblockplus/manifests/legacy/filterserver.pp

Issue 29527816: #2762 - Fix provisioning of geoip to filter servers (Closed)

Left Patch Set: For comment 2 Created Aug. 30, 2017, 1:54 a.m.

Right Patch Set: For comment 5 Created Aug. 30, 2017, 3:20 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # == Class: adblockplus::legacy::filterserver	1 # == Class: adblockplus::legacy::filterserver

2 #	2 #

3 # See http://hub.eyeo.com/issues/2762 for more information.	3 # See http://hub.eyeo.com/issues/2762 for more information.

4 #	4 #

5 class adblockplus::legacy::filterserver {	5 class adblockplus::legacy::filterserver {

6	6

7 include filterserver	7 include filterserver

8	8

9 # Manually installed package conflicts with geoip module
mathias 2017/08/30 08:47:36 Why would we use Puppet to ensure a manually insta Why would we use Puppet to ensure a manually installed package being purged? That's nonsense (despite someone maybe "fixing" the thus far missing include for class geoip in class nginx by over and over manually installing the package); We use puppet to purge the FORMERLY installed package.
10 package {'geoip-database-contrib':	9 package {'geoip-database-contrib':

11 ensure => 'purged',	10 ensure => 'purged',

12 }	11 }

13 }	12 }

14	13

LEFT	RIGHT