Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mozharness/abb/transform_locales.py

Issue 29527868: Issue 5580 - Multilocale build fails due to missing search engine plugin file (Closed)
Patch Set: Created Aug. 25, 2017, 9:55 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mozharness/abb/transform_locales.py
===================================================================
--- a/mozharness/abb/transform_locales.py
+++ b/mozharness/abb/transform_locales.py
@@ -161,19 +161,22 @@ def _transform_locale(locale, path, logg
removed_engine_ids.append(line)
# Make sure we still have search engines left
if len(engine_ids) == 0:
logger.fatal("No search engines left over for '%s'" % locale)
# 'Parse' XML to get matching 'ShortName' for all engine IDs
engine_names = {}
- for eid in engine_ids:
+ for eid in engine_ids[:]:
xml_file_path = os.path.join(path, _SEARCHPLUGINS_PATH, "%s.xml" % eid)
- _check_path_exists(xml_file_path, logger)
+ if not os.path.exists(xml_file_path):
+ logger.info("Missing xml file for plugin %s" % eid)
+ engine_ids.remove(eid)
+ continue
short_name = None
with open(xml_file_path, "r") as fd:
for line in fd:
line = line.strip()
match = _SHORTNAME_RE.match(line)
if match:
short_name = match.group(1).strip()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld