Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: build.py

Issue 29527871: Issue 5581 - Multilocale build fails to copy gecko-unsigned-unaligned.apk (Closed)
Patch Set: Created Aug. 25, 2017, 10:21 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build.py
===================================================================
--- a/build.py
+++ b/build.py
@@ -80,18 +80,19 @@ def _build(architecture, distribution_mo
env=build_environment)
dist_path = os.path.join(_ABB_PATH, obj_dir, "dist")
arch_suffix = _ARCH_X86_I386 if architecture == _ARCH_X86 else _ARCH_ARM
[manifest_path] = glob.glob(os.path.join(
dist_path, "fennec-*.multi.android-%s.json" % arch_suffix))
with open(manifest_path) as manifest_file:
manifest = json.load(manifest_file)
-
- apk_path = os.path.join(dist_path, "gecko-unsigned-unaligned.apk")
+ apk_name = "fennec-%s.multi.android-%s-unsigned-unaligned.apk" % (
+ manifest["moz_app_version"], architecture)
+ apk_path = os.path.join(dist_path, apk_name)
if build_mode == _BUILD_RELEASE:
target_apk_name = "adblockbrowser-%s-%s.apk" % (
manifest["moz_app_version"], architecture)
else:
target_apk_name = "adblockbrowser-%s.%s-%s.apk" % (
manifest["moz_app_version"], manifest["buildid"], architecture)
target_apk_path = os.path.join(dist_path, target_apk_name)
shutil.copyfile(apk_path, target_apk_path)
@@ -134,17 +135,17 @@ if __name__ == "__main__":
sys.exit(2)
if do_sign:
if len(sys.argv) < 3:
print_usage()
sys.exit(3)
apk_path = sys.argv[2]
- subprocess.check_call([_ENSURE_DEPENDENCIES_PATH])
+ # subprocess.check_call([_ENSURE_DEPENDENCIES_PATH])
import config
error_msg = "Invalid %s, check config.py. Supported %s: %s"
distribution_mode = config.DISTRIBUTION_MODE
if distribution_mode not in _DIST_MODES:
print >>sys.stderr, error_msg % (
"distribution mode", "distribution modes", _DIST_MODES)
sys.exit(4)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld