Issue 5582 - Workaround Edge bug in tabs.query

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 722 matching lines @@
     {
       // Edge does not yet support runtime.openOptionsPage (tested version 38)
       // nor does Firefox for Android,
       // and so this workaround needs to stay for now.
       // We are not using extension.getURL to get the absolute path here
       // because of the Edge issue:
       // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/
       let open = win =>
       {
         let optionsUrl = "options.html";
-        let queryInfo = {url: optionsUrl};
+        let queryInfo = {title: "Adblock Plus Options"};

[Oleksandr, 2017/08/25 22:59:31]

This is somewhat questionable, of course. It is possible for other third-party
pages to have that title as well. But I couldn't come up with any security
issues this could introduce, so I guess this should be fine. At least until the
bug is fixed.

[Sebastian Noack, 2017/08/26 06:41:10]

The title indeed doesn't seem to be translated, but this is a bug. Also
hard-coding this kind of details here, makes it harder and error-prone for other
products that are based on Adblock Plus. Can't we just go through all tabs and
match the URL ourselves?

 
         if (win)
           queryInfo.windowId = win.id;
 
         chrome.tabs.query(queryInfo, tabs =>
         {
           if (tabs && tabs.length > 0)
           {
             let tab = tabs[0];
 
@@ skipping 30 matching lines @@
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());