Issue 5582 - Workaround Edge bug in tabs.query

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 719 matching lines @@
       }
     }
     else
     {
       // Edge does not yet support runtime.openOptionsPage (tested version 38)
       // nor does Firefox for Android,
       // and so this workaround needs to stay for now.
       // We are not using extension.getURL to get the absolute path here
       // because of the Edge issue:
       // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/
       let open = win =>

[Sebastian Noack, 2017/08/29 02:08:21]

It seems the `win` argument is ignored now. Mind removing the argument and
simplifying the calling code?

       {
         let optionsUrl = "options.html";
-        let queryInfo = {url: optionsUrl};
+        let fullOptionsUrl = ext.getURL("options.html");
 
-        if (win)
-          queryInfo.windowId = win.id;
-
-        chrome.tabs.query(queryInfo, tabs =>
+        // We find a tab ourselves because Edge has a bug when quering tabs
+        // with extension URL protocol:
+        // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8094141/ 
+        // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8604703/
+        function isOptionsTab(element)
         {
-          if (tabs && tabs.length > 0)
+          return element.url == fullOptionsUrl;
+        }
+        chrome.tabs.query({}, tabs =>

[Oleksandr, 2017/08/28 01:38:36]

Passing {} is the only way to get all tabs, it seems. Providing windowId or url:
"<all_urls>" doesn't return extension pages.

+        {
+          if (tabs && (tabs.findIndex(isOptionsTab) >= 0))

[Sebastian Noack, 2017/08/29 02:08:21]

Calling findIndex()/find() twice is redundant. Just use find() once, store the
return value in a variable and check it. Also it might make the code easier to
read to use an arrow function here, rather than defining a named function above.

           {
-            let tab = tabs[0];
-
+            let tab = tabs.find(isOptionsTab);
             if ("windows" in chrome)
               chrome.windows.update(tab.windowId, {focused: true});
 
             chrome.tabs.update(tab.id, {active: true});
 
             if (callback)
               callback(new Page(tab));
           }
           else
           {
@@ skipping 20 matching lines @@
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());