Issue 5582 - Workaround Edge bug in tabs.query

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 714 matching lines @@
             {
               if (tabs[0].status == "complete")
                 callback(new Page(tabs[0]));
               else
                 afterTabLoaded(callback)(tabs[0]);
             }
           });
         });
       }
     }
-    else
+    else if ("windows" in chrome)
     {
       // Edge does not yet support runtime.openOptionsPage (tested version 38)
-      // nor does Firefox for Android before version 57,

[Oleksandr, 2017/08/29 11:49:58]

Remove this line, since this is really an Edge specific clause now.

       // and so this workaround needs to stay for now.
       // We are not using extension.getURL to get the absolute path here
       // because of the Edge issue:
       // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/
-      if ("windows" in chrome)
+      let optionsUrl = "options.html";
+      let fullOptionsUrl = ext.getURL(optionsUrl);
+
+      chrome.tabs.query({}, tabs =>
       {
-        chrome.windows.getLastFocused(win =>
+        // We find a tab ourselves because Edge has a bug when quering tabs
+        // with extension URL protocol:
+        // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8094141/ 
+        // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/8604703/
+        let tab = tabs.find(element => element.url == fullOptionsUrl);
+        if (tab)
         {
-          let optionsUrl = "options.html";
-          let queryInfo = {url: optionsUrl};
+          chrome.windows.update(tab.windowId, {focused: true});
+          chrome.tabs.update(tab.id, {active: true});
 
-          if (win)
-            queryInfo.windowId = win.id;
-
-          chrome.tabs.query(queryInfo, tabs =>
-          {
-            if (tabs.length > 0)
-            {
-              let tab = tabs[0];
-
-              if ("windows" in chrome)
-                chrome.windows.update(tab.windowId, {focused: true});
-
-              chrome.tabs.update(tab.id, {active: true});
-
-              if (callback)
-                callback(new Page(tab));
-            }
-            else
-            {
-              ext.pages.open(optionsUrl, callback);
-            }
-          });
-        });
-      }
-      else
-      {
-        // Firefox for Android does not support the windows API. Since there is
-        // effectively only one window on the mobile browser, there's no need
-        // to bring it into focus.
-        ext.pages.open("options.html", callback);
-      }
+          if (callback)
+            callback(new Page(tab));
+        }
+        else
+        {
+          ext.pages.open(optionsUrl, callback);
+        }
+      });
+    }
+    else
+    {
+      // Firefox for Android does not support the windows API. Since there is

[Manish Jethani, 2017/08/29 12:09:59]

Maybe it's a good idea to update this comment here since the other one has been
removed.

Something like: "Firefox for Android before version 57 does not support
runtime.openOptionsPage, nor does it support the windows API. Since ..."

+      // effectively only one window on the mobile browser, there's no need
+      // to bring it into focus.
+      ext.pages.open("options.html", callback);
     }
   };
 
   /* Windows */
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());