Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: ext/background.js

Issue 29527877: Issue 5582 - Workaround Edge bug in tabs.query (Closed)
Left Patch Set: Rebase to master tip Created Aug. 29, 2017, 11:48 a.m.
Right Patch Set: Update the comment about Firefox on Android Created Aug. 29, 2017, 4:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 747 matching lines...) Expand 10 before | Expand all | Expand 10 after
758 callback(new Page(tab)); 758 callback(new Page(tab));
759 } 759 }
760 else 760 else
761 { 761 {
762 ext.pages.open(optionsUrl, callback); 762 ext.pages.open(optionsUrl, callback);
763 } 763 }
764 }); 764 });
765 } 765 }
766 else 766 else
767 { 767 {
768 // Firefox for Android does not support the windows API. Since there is 768 // Firefox for Android before version 57 does not support
Manish Jethani 2017/08/29 12:09:59 Maybe it's a good idea to update this comment here
769 // effectively only one window on the mobile browser, there's no need 769 // runtime.openOptionsPage, nor does it support the windows API. Since
770 // to bring it into focus. 770 // there is effectively only one window on the mobile browser, there's no
771 // need to bring it into focus.
771 ext.pages.open("options.html", callback); 772 ext.pages.open("options.html", callback);
772 } 773 }
773 }; 774 };
774 775
775 /* Windows */ 776 /* Windows */
776 ext.windows = { 777 ext.windows = {
777 create(createData, callback) 778 create(createData, callback)
778 { 779 {
779 chrome.windows.create(createData, createdWindow => 780 chrome.windows.create(createData, createdWindow =>
780 { 781 {
781 afterTabLoaded(callback)(createdWindow.tabs[0]); 782 afterTabLoaded(callback)(createdWindow.tabs[0]);
782 }); 783 });
783 } 784 }
784 }; 785 };
785 }()); 786 }());
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld