Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(337)

Issue 29529779: Issue 5586 - Replaced toggle.png with toggle.svg (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 3 months ago by Thomas Greiner
Modified:
2 years, 3 months ago
Reviewers:
saroyanm
Visibility:
Public.

Description

Issue 5586 - Replaced toggle.png with toggle.svg

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M skin/mobile-options.css View 1 chunk +2 lines, -2 lines 0 comments Download
A skin/mobile/toggle.svg View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Thomas Greiner
2 years, 3 months ago (2017-08-28 17:50:53 UTC) #1
saroyanm
Awesome, that's exactly what I needed just right now :D Did you made it ? ...
2 years, 3 months ago (2017-08-28 17:58:14 UTC) #2
Thomas Greiner
2 years, 3 months ago (2017-08-29 09:14:31 UTC) #3
Message was sent while issue was closed.
On 2017/08/28 17:58:14, saroyanm wrote:
> Awesome, that's exactly what I needed just right now :D

Great to hear but be careful with it because I noticed that it may not work
properly in Chrome for some reason.

In case it helps, here are some resources I've used:
- https://css-tricks.com/svg-fragment-identifiers-work/
- https://developer.mozilla.org/en-US/docs/Web/SVG/Element/view

> Did you made it ? Looks awesome and LGTM.

Thanks. Yeah, I basically took the two SVGs that are in the spec draft, put them
into a single SVG file, offset one of them vertically to create the sprite and
added the views. I'll create a spec ticket to replace them there as well.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5