Issue 5592 - Remove synced devices from history

mobile/android/base/java/org/mozilla/gecko/home/CombinedHistoryAdapter.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 20; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 package org.mozilla.gecko.home;
 
 import android.content.res.Resources;
 import android.support.annotation.UiThread;
 import android.support.v7.widget.LinearLayoutManager;
 import android.support.v7.widget.RecyclerView;
@@ skipping 68 matching lines @@
     public interface DevicesUpdateHandler {
         void onDeviceCountUpdated(int count);
     }
 
     public DevicesUpdateHandler getDeviceUpdateHandler() {
         if (devicesUpdateHandler == null) {
             devicesUpdateHandler = new DevicesUpdateHandler() {
                 @Override
                 public void onDeviceCountUpdated(int count) {
                     deviceCount = count;
-                    notifyItemChanged(getSyncedDevicesSmartFolderIndex());
+                    // Removed notifyItemChanged call. See https://issues.adblockplus.org/ticket/5592
                 }
             };
         }
         return devicesUpdateHandler;
     }
 
     public interface RecentTabsUpdateHandler {
         void onRecentTabsCountUpdated(int count, boolean countReliable);
     }
 
@@ skipping 65 matching lines @@
     }
 
     @UiThread
     private boolean isRecentTabsFolderVisible() {
         return recentTabsCount > 0;
     }
 
     @UiThread
     // Number of smart folders for determining practical empty state.
     public int getNumVisibleSmartFolders() {
-        int visibleFolders = 1; // Synced devices folder is always visible.
+        // Synced devices folder is always hidden. See https://issues.adblockplus.org/ticket/5592
+        int visibleFolders = 0;
 
         if (isRecentTabsFolderVisible()) {
             visibleFolders += 1;
         }
 
         return visibleFolders;
     }
 
     @UiThread
     private int getSyncedDevicesSmartFolderIndex() {
@@ skipping 73 matching lines @@
         } else {
             return position;
         }
     }
 
     @UiThread
     private CombinedHistoryItem.ItemType getItemTypeForPosition(int position) {
         if (position == RECENT_TABS_SMARTFOLDER_INDEX && isRecentTabsFolderVisible()) {
             return CombinedHistoryItem.ItemType.RECENT_TABS;
         }
-        if (position == getSyncedDevicesSmartFolderIndex()) {
+        // We never show the synced devices item. See https://issues.adblockplus.org/ticket/5592
+        if (false) {
             return CombinedHistoryItem.ItemType.SYNCED_DEVICES;
         }
         final int sectionPosition = transformAdapterPositionForDataStructure(CombinedHistoryItem.ItemType.SECTION_HEADER, position);
         if (sectionHeaders.get(sectionPosition) != null) {
             return CombinedHistoryItem.ItemType.SECTION_HEADER;
         }
         return CombinedHistoryItem.ItemType.HISTORY;
     }
 
     @UiThread
@@ skipping 144 matching lines @@
             // If this is a combined cursor, we may get a history item without a
             // bookmark, in which case the bookmarks ID column value will be null.
             info.bookmarkId =  -1;
         } else {
             info.bookmarkId = cursor.getInt(bookmarkIdCol);
         }
         return info;
     }
 
 }