Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 29530594: Issue 5536 - Update ABP dependency to version 2.9.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by diegocarloslima
Modified:
2 years, 2 months ago
Reviewers:
jens, anton
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5536 - Update ABP dependency to version 2.9.1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M dependencies View 1 chunk +2 lines, -2 lines 2 comments Download
M mobile/android/installer/allowed-dupes.mn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
2 years, 2 months ago (2017-08-29 18:44:05 UTC) #1
jens
https://codereview.adblockplus.org/29530594/diff/29530595/dependencies File dependencies (right): https://codereview.adblockplus.org/29530594/diff/29530595/dependencies#newcode4 dependencies:4: buildtools = buildtools hg:daa9df1ee39f git:3ab934a Are we forced to ...
2 years, 2 months ago (2017-08-30 10:11:52 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29530594/diff/29530595/dependencies File dependencies (right): https://codereview.adblockplus.org/29530594/diff/29530595/dependencies#newcode4 dependencies:4: buildtools = buildtools hg:daa9df1ee39f git:3ab934a On 2017/08/30 10:11:52, jens ...
2 years, 2 months ago (2017-09-04 10:53:40 UTC) #3
anton
On 2017/09/04 10:53:40, diegocarloslima wrote: > https://codereview.adblockplus.org/29530594/diff/29530595/dependencies > File dependencies (right): > > https://codereview.adblockplus.org/29530594/diff/29530595/dependencies#newcode4 > ...
2 years, 2 months ago (2017-09-04 10:55:03 UTC) #4
jens
2 years, 2 months ago (2017-09-05 09:13:28 UTC) #5
On 2017/09/04 10:53:40, diegocarloslima wrote:
> https://codereview.adblockplus.org/29530594/diff/29530595/dependencies
> File dependencies (right):
> 
>
https://codereview.adblockplus.org/29530594/diff/29530595/dependencies#newcode4
> dependencies:4: buildtools = buildtools hg:daa9df1ee39f git:3ab934a
> On 2017/08/30 10:11:52, jens wrote:
> > Are we forced to use this exact version of buildtools? It is already 5 month
> > old. Sorry if this is a stupid question.
> 
> Since we use the buildtools just to build/package the ABP extension, its good
to
> be in accordance with the version used by the extension itself:
> https://hg.adblockplus.org/adblockplus/file/2.9.1/dependencies

Then LGTM :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5