Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: lib/stats.js

Issue 29530598: Issue 5588 - Explicitly clear badge text on tab update (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Add link to Firefox bug Created Aug. 30, 2017, 10:23 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 16 matching lines...) Expand all
27 let blockedPerPage = new ext.PageMap(); 27 let blockedPerPage = new ext.PageMap();
28 28
29 /** 29 /**
30 * Gets the number of requests blocked on the given page. 30 * Gets the number of requests blocked on the given page.
31 * 31 *
32 * @param {Page} page 32 * @param {Page} page
33 * @return {Number} 33 * @return {Number}
34 */ 34 */
35 exports.getBlockedPerPage = page => blockedPerPage.get(page) || 0; 35 exports.getBlockedPerPage = page => blockedPerPage.get(page) || 0;
36 36
37 // Chrome automatically clears the browser action badge text when the URL of
38 // the tab is updated, but Firefox doesn't.
39 // https://bugzilla.mozilla.org/show_bug.cgi?id=1395074
40 ext.pages.onLoading.addListener(page =>
41 {
42 page.browserAction.setBadge();
43 });
44
37 FilterNotifier.on("filter.hitCount", (filter, newValue, oldValue, page) => 45 FilterNotifier.on("filter.hitCount", (filter, newValue, oldValue, page) =>
38 { 46 {
39 if (!(filter instanceof BlockingFilter) || !page) 47 if (!(filter instanceof BlockingFilter) || !page)
40 return; 48 return;
41 49
42 Prefs.blocked_total++; 50 Prefs.blocked_total++;
43 51
44 let blocked = blockedPerPage.get(page) || 0; 52 let blocked = blockedPerPage.get(page) || 0;
45 blockedPerPage.set(page, ++blocked); 53 blockedPerPage.set(page, ++blocked);
46 54
(...skipping 24 matching lines...) Expand all
71 color: badgeColor, 79 color: badgeColor,
72 number: blocked 80 number: blocked
73 }; 81 };
74 } 82 }
75 } 83 }
76 84
77 page.browserAction.setBadge(badge); 85 page.browserAction.setBadge(badge);
78 } 86 }
79 }); 87 });
80 }); 88 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld