Issue 5588 - Explicitly clear badge text on tab update

lib/stats.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 17 matching lines @@
 
 /**
  * Gets the number of requests blocked on the given page.
  *
  * @param  {Page} page
  * @return {Number}
  */
 exports.getBlockedPerPage = page => blockedPerPage.get(page) || 0;
 
 // Chrome automatically clears the browser action badge text when the URL of
 // the tab is updated, but Firefox doesn't.

[Sebastian Noack, 2017/08/29 23:07:01]

Please refer to the Firefox bug here. If there isn't one yet, please file one.

[Wladimir Palant, 2017/08/30 08:13:30]

I filed a bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1395074

[Manish Jethani, 2017/08/30 10:30:35]

Done.

+// https://bugzilla.mozilla.org/show_bug.cgi?id=1395074
 ext.pages.onLoading.addListener(page =>
 {
   page.browserAction.setBadge();
 });
 
 FilterNotifier.on("filter.hitCount", (filter, newValue, oldValue, page) =>
 {
   if (!(filter instanceof BlockingFilter) || !page)
     return;
 
@@ skipping 29 matching lines @@
             color: badgeColor,
             number: blocked
           };
         }
       }
 
       page.browserAction.setBadge(badge);
     }
   });
 });