Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29531677: Issue 5599 - ext needs to be defined in the postload script (Closed)

Created:
Aug. 30, 2017, 3:23 p.m. by hub
Modified:
Sept. 11, 2017, 12:38 p.m.
CC:
kzar, Manish Jethani
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5599 - ext needs to be defined in the postload script

Patch Set 1 #

Total comments: 1

Patch Set 2 : New approach as discussed in the bug #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -165 lines) Patch
M ext/background.js View 1 1 chunk +1 line, -1 line 1 comment Download
M lib/composer.js View 1 1 chunk +96 lines, -90 lines 0 comments Download
M lib/subscriptionLink.js View 1 1 chunk +75 lines, -70 lines 0 comments Download
M metadata.chrome View 1 2 chunks +7 lines, -4 lines 1 comment Download
A postload.preload.js View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8
hub
Aug. 30, 2017, 3:23 p.m. (2017-08-30 15:23:30 UTC) #1
hub
https://codereview.adblockplus.org/29531677/diff/29531678/metadata.chrome File metadata.chrome (right): https://codereview.adblockplus.org/29531677/diff/29531678/metadata.chrome#newcode44 metadata.chrome:44: document_end = ext/common.js ext/content.js include.postload.js it seems that in ...
Aug. 30, 2017, 3:25 p.m. (2017-08-30 15:25:01 UTC) #2
kzar
(Copying in Manish and Wladimir.)
Aug. 30, 2017, 3:31 p.m. (2017-08-30 15:31:37 UTC) #3
hub
Seems that this is not the right solution.
Aug. 30, 2017, 5:07 p.m. (2017-08-30 17:07:59 UTC) #4
Sebastian Noack
On 2017/08/30 17:07:59, hub wrote: > Seems that this is not the right solution. Yeah, ...
Aug. 30, 2017, 6:17 p.m. (2017-08-30 18:17:34 UTC) #5
hub
On 2017/08/30 18:17:34, Sebastian Noack wrote: > On 2017/08/30 17:07:59, hub wrote: > > Seems ...
Aug. 30, 2017, 6:19 p.m. (2017-08-30 18:19:36 UTC) #6
hub
This is a new approach in line with what has been discussed. I have tested ...
Sept. 1, 2017, 8:41 p.m. (2017-09-01 20:41:36 UTC) #7
hub
Sept. 11, 2017, 12:37 p.m. (2017-09-11 12:37:57 UTC) #8
Upstream bug is fixed for Firefox 57. Closing this review.

Powered by Google App Engine
This is Rietveld