Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: build.py

Issue 29531680: Issue 5560 - Specify the JSDoc dependency explicitly (Closed)
Left Patch Set: Addressed nit Created Aug. 31, 2017, 10:51 a.m.
Right Patch Set: Readdressed nit Created Aug. 31, 2017, 12:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | package.json » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This Source Code Form is subject to the terms of the Mozilla Public 1 # This Source Code Form is subject to the terms of the Mozilla Public
2 # License, v. 2.0. If a copy of the MPL was not distributed with this 2 # License, v. 2.0. If a copy of the MPL was not distributed with this
3 # file, You can obtain one at http://mozilla.org/MPL/2.0/. 3 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
4 4
5 import os 5 import os
6 import sys 6 import sys
7 import re 7 import re
8 import subprocess 8 import subprocess
9 import shutil 9 import shutil
10 import buildtools 10 import buildtools
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 512
513 with addCommand(showDescriptions, 'showdesc') as command: 513 with addCommand(showDescriptions, 'showdesc') as command:
514 command.shortDescription = 'Print description strings for all locales' 514 command.shortDescription = 'Print description strings for all locales'
515 command.description = 'Display description strings for all locales as specif ied in the corresponding meta.properties files.' 515 command.description = 'Display description strings for all locales as specif ied in the corresponding meta.properties files.'
516 command.addOption('Only include the given locales', short='l', long='locales ', value='l1,l2,l3') 516 command.addOption('Only include the given locales', short='l', long='locales ', value='l1,l2,l3')
517 command.params = '[options]' 517 command.params = '[options]'
518 command.supportedTypes = ('gecko') 518 command.supportedTypes = ('gecko')
519 519
520 with addCommand(generateDocs, 'docs') as command: 520 with addCommand(generateDocs, 'docs') as command:
521 command.shortDescription = 'Generate documentation (requires node.js)' 521 command.shortDescription = 'Generate documentation (requires node.js)'
522 command.description = 'Generate documentation files and write them into ' \ 522 command.description = ('Generate documentation files and write them into '
523 'the specified directory.' 523 'the specified directory.')
tlucas 2017/08/31 12:20:58 Sorry for bothering, PEP 8 prefers implicit contin
kzar 2017/08/31 12:24:54 Done.
524 command.addOption('Suppress JsDoc output', short='q', long='quiet') 524 command.addOption('Suppress JsDoc output', short='q', long='quiet')
525 command.params = '[options] <directory>' 525 command.params = '[options] <directory>'
526 command.supportedTypes = ('gecko', 'chrome') 526 command.supportedTypes = ('gecko', 'chrome')
527 527
528 with addCommand(runReleaseAutomation, 'release') as command: 528 with addCommand(runReleaseAutomation, 'release') as command:
529 command.shortDescription = 'Run release automation' 529 command.shortDescription = 'Run release automation'
530 command.description = 'Note: If you are not the project owner then you ' "probably don't want to run this!\n\n" 'Runs release automation: crea tes downloads for the new version, tags ' 'source code repository as well as downloads and buildtools repository.' 530 command.description = 'Note: If you are not the project owner then you ' "probably don't want to run this!\n\n" 'Runs release automation: crea tes downloads for the new version, tags ' 'source code repository as well as downloads and buildtools repository.'
531 command.addOption('File containing private key and certificates required to sign the release.', short='k', long='key', value='file', types=('chrome', 'safar i', 'edge')) 531 command.addOption('File containing private key and certificates required to sign the release.', short='k', long='key', value='file', types=('chrome', 'safar i', 'edge'))
532 command.addOption('Directory containing downloads repository (if omitted ../ downloads is assumed)', short='d', long='downloads', value='dir') 532 command.addOption('Directory containing downloads repository (if omitted ../ downloads is assumed)', short='d', long='downloads', value='dir')
533 command.params = '[options] <version>' 533 command.params = '[options] <version>'
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 if option in ('-h', '--help'): 604 if option in ('-h', '--help'):
605 usage(scriptName, type, command) 605 usage(scriptName, type, command)
606 sys.exit() 606 sys.exit()
607 commands[command](baseDir, scriptName, opts, args, type) 607 commands[command](baseDir, scriptName, opts, args, type)
608 else: 608 else:
609 print 'Command %s is not supported for this application type' % comm and 609 print 'Command %s is not supported for this application type' % comm and
610 usage(scriptName, type) 610 usage(scriptName, type)
611 else: 611 else:
612 print 'Command %s is unrecognized' % command 612 print 'Command %s is unrecognized' % command
613 usage(scriptName, type) 613 usage(scriptName, type)
LEFTRIGHT
« no previous file | package.json » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld