Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Side by Side Diff: popup.html

Issue 29532767: Issue 5593 - Use messaging in popup for prefs, whitelisting, and stats (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Use messaging for prefs I/O Created Aug. 31, 2017, 5:07 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | popup.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 2
3 <!-- 3 <!--
4 - This file is part of Adblock Plus <https://adblockplus.org/>, 4 - This file is part of Adblock Plus <https://adblockplus.org/>,
5 - Copyright (C) 2006-present eyeo GmbH 5 - Copyright (C) 2006-present eyeo GmbH
6 - 6 -
7 - Adblock Plus is free software: you can redistribute it and/or modify 7 - Adblock Plus is free software: you can redistribute it and/or modify
8 - it under the terms of the GNU General Public License version 3 as 8 - it under the terms of the GNU General Public License version 3 as
9 - published by the Free Software Foundation. 9 - published by the Free Software Foundation.
10 - 10 -
11 - Adblock Plus is distributed in the hope that it will be useful, 11 - Adblock Plus is distributed in the hope that it will be useful,
12 - but WITHOUT ANY WARRANTY; without even the implied warranty of 12 - but WITHOUT ANY WARRANTY; without even the implied warranty of
13 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 13 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 - GNU General Public License for more details. 14 - GNU General Public License for more details.
15 - 15 -
16 - You should have received a copy of the GNU General Public License 16 - You should have received a copy of the GNU General Public License
17 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 17 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
18 --> 18 -->
19 19
20 <html> 20 <html>
21 <head> 21 <head>
22 <meta charset="utf-8"> 22 <meta charset="utf-8">
23 <link rel="stylesheet" type="text/css" href="skin/popup.css"> 23 <link rel="stylesheet" type="text/css" href="skin/popup.css">
24 <script src="ext/common.js"></script> 24 <script src="ext/common.js"></script>
25 <script src="ext/content.js"></script>
Wladimir Palant 2017/08/31 18:19:32 Do we need this? The messaging uses Chrome APIs di
Manish Jethani 2017/09/01 15:56:19 Right, it's not required. I've removed it now.
25 <script src="ext/popup.js"></script> 26 <script src="ext/popup.js"></script>
26 <script src="i18n.js"></script> 27 <script src="i18n.js"></script>
27 <script src="popup.js"></script> 28 <script src="popup.js"></script>
28 <script src="notification.js"></script> 29 <script src="notification.js"></script>
29 <script src="stats.js"></script> 30 <script src="stats.js"></script>
30 </head> 31 </head>
31 <!-- Set tabindex to work around Chromium issue 304532 --> 32 <!-- Set tabindex to work around Chromium issue 304532 -->
32 <body tabindex="1"> 33 <body tabindex="1">
33 34
34 <header> 35 <header>
(...skipping 28 matching lines...) Expand all
63 64
64 <li id="clickhide" class="menu-item" role="button"> 65 <li id="clickhide" class="menu-item" role="button">
65 <div class="icon"></div> 66 <div class="icon"></div>
66 <span class="i18n_easy_create_filter"></span> 67 <span class="i18n_easy_create_filter"></span>
67 </li> 68 </li>
68 <li id="clickhide-cancel" class="menu-item" role="button"> 69 <li id="clickhide-cancel" class="menu-item" role="button">
69 <div class="icon"></div> 70 <div class="icon"></div>
70 <span class="i18n_cancel"></span> 71 <span class="i18n_cancel"></span>
71 </li> 72 </li>
72 73
73 <li id="stats-container"> 74 <li id="stats-container" class="collapsed">
Manish Jethani 2017/08/31 17:12:21 Collapsed by default.
74 <div class="menu-item collapse" data-option="show_statsinpopup" data-colla psable="stats-container" role="button"> 75 <div class="menu-item collapse" data-option="show_statsinpopup" data-colla psible="stats-container" role="button">
75 <div class="icon"></div> 76 <div class="icon"></div>
76 <span class="i18n_stats_title"></span> 77 <span class="i18n_stats_title"></span>
77 <div class="collapse-icon-placeholder"></div> 78 <div class="collapse-icon-placeholder"></div>
78 <div class="collapse-icon"></div> 79 <div class="collapse-icon"></div>
79 </div> 80 </div>
80 <ul id="stats" class="collapsable"> 81 <ul id="stats" class="collapsible">
Manish Jethani 2017/08/31 17:12:21 This has been renamed as per Thomas's suggestion,
81 <li> 82 <li>
82 <div> 83 <div>
83 <div id="stats-page"></div> 84 <div id="stats-page"></div>
84 <div id="stats-total"></div> 85 <div id="stats-total"></div>
85 </div> 86 </div>
86 87
87 <div id="share"> 88 <div id="share">
88 <span class="i18n_stats_share_title"></span> 89 <span class="i18n_stats_share_title"></span>
89 <div id="share-box"> 90 <div id="share-box">
90 <div data-social="facebook"></div> 91 <div data-social="facebook"></div>
(...skipping 11 matching lines...) Expand all
102 </ul> 103 </ul>
103 </div> 104 </div>
104 105
105 <footer id="options" role="button"> 106 <footer id="options" role="button">
106 <div class="icon"></div> 107 <div class="icon"></div>
107 <span class="i18n_options_short"></span> 108 <span class="i18n_options_short"></span>
108 </footer> 109 </footer>
109 110
110 </body> 111 </body>
111 </html> 112 </html>
OLDNEW
« no previous file with comments | « no previous file | popup.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld