Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: notification.js

Issue 29532767: Issue 5593 - Use messaging in popup for prefs, whitelisting, and stats (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Check for page ready again after adding listener Created Sept. 19, 2017, 8:54 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « lib/filterComposer.js ('k') | popup.html » ('j') | popup.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 messageElement.addEventListener("click", event => 76 messageElement.addEventListener("click", event =>
77 { 77 {
78 let link = event.target; 78 let link = event.target;
79 while (link && link !== messageElement && link.localName !== "a") 79 while (link && link !== messageElement && link.localName !== "a")
80 link = link.parentNode; 80 link = link.parentNode;
81 if (!link) 81 if (!link)
82 return; 82 return;
83 event.preventDefault(); 83 event.preventDefault();
84 event.stopPropagation(); 84 event.stopPropagation();
85 ext.pages.open(link.href); 85 chrome.tabs.create({url: link.href});
86 }); 86 });
87 87
88 let notificationElement = document.getElementById("notification"); 88 let notificationElement = document.getElementById("notification");
89 notificationElement.className = notification.type; 89 notificationElement.className = notification.type;
90 notificationElement.hidden = false; 90 notificationElement.hidden = false;
91 notificationElement.addEventListener("click", event => 91 notificationElement.addEventListener("click", event =>
92 { 92 {
93 if (event.target.id == "notification-close") 93 if (event.target.id == "notification-close")
94 notificationElement.classList.add("closing"); 94 notificationElement.classList.add("closing");
95 else if (event.target.id == "notification-optout" || 95 else if (event.target.id == "notification-optout" ||
96 event.target.id == "notification-hide") 96 event.target.id == "notification-hide")
97 { 97 {
98 if (event.target.id == "notification-optout") 98 if (event.target.id == "notification-optout")
99 Notification.toggleIgnoreCategory("*", true); 99 Notification.toggleIgnoreCategory("*", true);
100 100
101 notificationElement.hidden = true; 101 notificationElement.hidden = true;
102 notification.onClicked(); 102 notification.onClicked();
103 } 103 }
104 }, true); 104 }, true);
105 }, false); 105 }, false);
OLDNEW
« no previous file with comments | « lib/filterComposer.js ('k') | popup.html » ('j') | popup.js » ('J')

Powered by Google App Engine
This is Rietveld