Issue 5593 - Use messaging in popup for prefs, whitelisting, and stats

stats.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* global i18n */
+/* global i18n, getPref, togglePref */
 
 "use strict";
 
 (function()
 {
   const {require} = ext.backgroundPage.getWindow();
 
   const {FilterNotifier} = require("filterNotifier");
 
   let currentTab;
@@ skipping 97 matching lines @@
   function share(ev)
   {
     getPref("blocked_total", blockedTotal =>
     {
       // Easter Egg
       if (blockedTotal <= 9000 || blockedTotal >= 10000)
         blockedTotal = blockedTotal.toLocaleString();
       else
         blockedTotal = i18n.getMessage("stats_over", (9000).toLocaleString());
 
-      chrome.tabs.create({
-        url: createShareLink(ev.target.dataset.social, blockedTotal)
-      });
+      ext.pages.open(createShareLink(ev.target.dataset.social, blockedTotal));

[Manish Jethani, 2017/09/27 09:42:32]

Sorry, I forgot this one.

     });
   }
 
   function toggleIconNumber()
   {
     togglePref("show_statsinicon", showStatsInIcon =>
     {
       document.getElementById("show-iconnumber").setAttribute(
         "aria-checked", showStatsInIcon
       );
     });
   }
 
   document.addEventListener("DOMContentLoaded", onLoad, false);
   window.addEventListener("unload", onUnload, false);
 }());