Unified Diff: popup.html
Issue 29532767:
Issue 5593 - Use messaging in popup for prefs, whitelisting, and stats (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Use messaging for prefs I/O
Created Aug. 31, 2017, 5:07 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
popup.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: popup.html |
| =================================================================== |
| --- a/popup.html |
| +++ b/popup.html |
| @@ -17,16 +17,17 @@ |
| - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. |
| --> |
| <html> |
| <head> |
| <meta charset="utf-8"> |
| <link rel="stylesheet" type="text/css" href="skin/popup.css"> |
| <script src="ext/common.js"></script> |
| + <script src="ext/content.js"></script> |
|
Wladimir Palant
2017/08/31 18:19:32
Do we need this? The messaging uses Chrome APIs di
Manish Jethani
2017/09/01 15:56:19
Right, it's not required. I've removed it now.
|
| <script src="ext/popup.js"></script> |
| <script src="i18n.js"></script> |
| <script src="popup.js"></script> |
| <script src="notification.js"></script> |
| <script src="stats.js"></script> |
| </head> |
| <!-- Set tabindex to work around Chromium issue 304532 --> |
| <body tabindex="1"> |
| @@ -65,24 +66,24 @@ |
| <div class="icon"></div> |
| <span class="i18n_easy_create_filter"></span> |
| </li> |
| <li id="clickhide-cancel" class="menu-item" role="button"> |
| <div class="icon"></div> |
| <span class="i18n_cancel"></span> |
| </li> |
| - <li id="stats-container"> |
| - <div class="menu-item collapse" data-option="show_statsinpopup" data-collapsable="stats-container" role="button"> |
| + <li id="stats-container" class="collapsed"> |
|
Manish Jethani
2017/08/31 17:12:21
Collapsed by default.
|
| + <div class="menu-item collapse" data-option="show_statsinpopup" data-collapsible="stats-container" role="button"> |
| <div class="icon"></div> |
| <span class="i18n_stats_title"></span> |
| <div class="collapse-icon-placeholder"></div> |
| <div class="collapse-icon"></div> |
| </div> |
| - <ul id="stats" class="collapsable"> |
| + <ul id="stats" class="collapsible"> |
|
Manish Jethani
2017/08/31 17:12:21
This has been renamed as per Thomas's suggestion,
|
| <li> |
| <div> |
| <div id="stats-page"></div> |
| <div id="stats-total"></div> |
| </div> |
| <div id="share"> |
| <span class="i18n_stats_share_title"></span> |
« no previous file with comments
|
« no previous file
|
popup.js » ('j')
|
no next file with comments »
