notification.js - Issue 29532767: Issue 5593 - Use messaging in popup for prefs, whitelisting, and stats

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: notification.js

Issue 29532767: Issue 5593 - Use messaging in popup for prefs, whitelisting, and stats (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Patch Set: Check for page ready again after adding listener Created Sept. 19, 2017, 8:54 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: notification.js

===================================================================

--- a/notification.js

+++ b/notification.js

@@ -77,17 +77,17 @@

{

let link = event.target;

while (link && link !== messageElement && link.localName !== "a")

link = link.parentNode;

if (!link)

return;

event.preventDefault();

event.stopPropagation();

- ext.pages.open(link.href);

+ chrome.tabs.create({url: link.href});

});

let notificationElement = document.getElementById("notification");

notificationElement.className = notification.type;

notificationElement.hidden = false;

notificationElement.addEventListener("click", event =>

{

if (event.target.id == "notification-close")

« no previous file with comments | « lib/filterComposer.js ('k') | popup.html » ('j') | popup.js » ('J')