Issue 5593 - Use messaging in popup for prefs, whitelisting, and stats

ext/popup.js

Index: ext/popup.js
===================================================================
--- a/ext/popup.js
+++ b/ext/popup.js
@@ -2,29 +2,29 @@
 
 (function()
 {
   if (typeof chrome == "undefined" || typeof chrome.extension == "undefined")
     window.chrome = browser;
   const backgroundPage = chrome.extension.getBackgroundPage();
   window.ext = Object.create(backgroundPage.ext);
 
-  window.ext.closePopup = () =>
-  {
-    window.close();
-  };

[Sebastian Noack, 2017/09/20 18:57:02]

It seems you need to rebase. There is no closePopup() in here anymore, as of the
current "next" bookmark.

[Manish Jethani, 2017/09/21 06:11:16]

OK, I'll rebase on master instead once next has been merged, which I'm guessing
is soon.

[Sebastian Noack, 2017/09/21 22:57:16]

Why not rebasing against "next" now? If the patch applies on "next", it will
also apply on "master", once "next" has been merged. But it makes it
unnecessarily difficult to review changes based on outdated code, and if a merge
conflict needs to be resolved later, I'd have to review the changes again.

[Manish Jethani, 2017/09/24 21:25:32]

Done.

-
   // Calling i18n.getMessage from the background page causes Edge to throw an
   // exception.
   // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12793975/
   window.ext.i18n = chrome.i18n;
 
   // We have to override ext.backgroundPage, because in order
   // to send messages the local "chrome" namespace must be used.
   window.ext.backgroundPage = {
     sendMessage: chrome.runtime.sendMessage,
 
     getWindow()
     {
       return backgroundPage;
     }
   };
+
+  window.ext.closePopup = () =>
+  {
+    window.close();
+  };
 }());