Issue 5588 - Clear badge text only if zero hits

Issue 5588 - Clear badge text only if zero hits

Chrome dispatches the loading event after the page has already started getting hits. If the stats module clears the text at this time, it can remain cleared if all the hits have already been counted.

This behavior can be observed by opening a new tab and quickly typing the URL and hitting Enter. If the page has only one hit, it'll be cleared from the badge.

Since the blockedPerPage map should return null for a page that is just starting to load, we check the value here. This solution works for both Firefox and Chrome.

[Manish Jethani, 2017-08-31 17:53:43]

Patch Set 1

Chrome dispatches the loading event after the page has already started getting
hits. If the stats module clears the text at this time, it can remain cleared if
all the hits have already been counted.

This behavior can be observed by opening a new tab and quickly typing the URL
and hitting Enter. If the page has only one hit, it'll be cleared from the
badge.

Since the blockedPerPage map should return null for a page that is just starting
to load, we check the value here. This solution works for both Firefox and
Chrome.

[Wladimir Palant, 2017-08-31 18:21:43]

LGTM

[Sebastian Noack, 2017-08-31 18:40:35]

LGTM