Issue 5593 - Return new value from prefs.toggle

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 329 matching lines @@
         {
           sendMessage("pref", preference, Prefs[preference]);
         });
       }
     }
   });
 
   port.on("prefs.toggle", (message, sender) =>
   {
     if (message.key == "notifications_ignoredcategories")
-      NotificationStorage.toggleIgnoreCategory("*");
-    else
-      Prefs[message.key] = !Prefs[message.key];
+      return NotificationStorage.toggleIgnoreCategory("*");

[Manish Jethani, 2017/09/01 12:08:38]

It's OK to return undefined here since it's a special case.

[Thomas Greiner, 2017/09/04 10:44:19]

Acknowledged.

+
+    return Prefs[message.key] = !Prefs[message.key];

[Thomas Greiner, 2017/09/04 10:44:19]

I assume you're planning to use it in
https://codereview.adblockplus.org/29532767/diff/29533671/stats.js, correct?
Because I don't see the return value being used anywhere.

[Manish Jethani, 2017/09/04 11:30:02]

Yes, specifically line 140 here in the new code:

https://codereview.adblockplus.org/29532767/diff/29533671/stats.js#newcode140

   });
 
   port.on("subscriptions.add", (message, sender) =>
   {
     let subscription = Subscription.fromURL(message.url);
     if ("title" in message)
       subscription.title = message.title;
     if ("homepage" in message)
       subscription.homepage = message.homepage;
 
@@ skipping 71 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);