Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/IFileSystem.h

Issue 29535572: Issue 5183 - make FileSystemPtr std::unique_ptr (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created Sept. 4, 2017, 9:59 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/BaseJsTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 /** 118 /**
119 * Retrieves information about a file. 119 * Retrieves information about a file.
120 * @param fileName File name. 120 * @param fileName File name.
121 * @param callback The function called on completion. 121 * @param callback The function called on completion.
122 */ 122 */
123 virtual void Stat(const std::string& fileName, 123 virtual void Stat(const std::string& fileName,
124 const StatCallback& callback) const = 0; 124 const StatCallback& callback) const = 0;
125 }; 125 };
126 126
127 /** 127 /**
128 * Shared smart pointer to a `IFileSystem` instance. 128 * Unique smart pointer to to a `IFileSystem` instance.
129 */ 129 */
130 typedef std::shared_ptr<IFileSystem> FileSystemPtr; 130 typedef std::unique_ptr<IFileSystem> FileSystemPtr;
131 } 131 }
132 132
133 #endif 133 #endif
OLDNEW
« no previous file with comments | « no previous file | test/BaseJsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld