Issue 5183 - make FileSystemPtr std::unique_ptr

test/Prefs.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #include <sstream>
 
 #include "../src/Thread.h"
 #include "BaseJsTest.h"
 
 using namespace AdblockPlus;
 
 namespace
 {
   class TestFileSystem : public LazyFileSystem
   {
+    IOBuffer& prefsContents;
   public:
-    IOBuffer prefsContents;
-
+    explicit TestFileSystem(IOBuffer& prefsContent)
+      : prefsContents(prefsContent)
+    {
+    }
     void Read(const std::string& fileName, const ReadCallback& callback) const override
     {
       scheduler([this, fileName, callback]
       {
         if (fileName == "prefs.json" && !prefsContents.empty())
         {
           callback(IOBuffer(prefsContents.cbegin(), prefsContents.cend()), "");
           return;
         }
 
@@ skipping 25 matching lines @@
           return;
         }
 
         LazyFileSystem::Stat(fileName, callback);
       });
     }
   };
 
   class PrefsTest : public BaseJsTest
   {
+    LazyFileSystem* fileSystem;
   protected:
-    std::shared_ptr<TestFileSystem> fileSystem;
+    IFileSystem::IOBuffer prefsContent;
 
     void SetUp()
     {
-      fileSystem = std::make_shared<TestFileSystem>();
       ResetPlatform();
     }
 
     void ResetPlatform()
     {
       ThrowingPlatformCreationParameters platformParams;
-      platformParams.fileSystem = fileSystem;
+      platformParams.fileSystem.reset(fileSystem = new TestFileSystem(prefsContent));
       platformParams.webRequest.reset(new NoopWebRequest());
       platformParams.logSystem.reset(new LazyLogSystem());
       platformParams.timer.reset(new NoopTimer());
       platform.reset(new Platform(std::move(platformParams)));
     }
 
     FilterEngine& CreateFilterEngine(const AdblockPlus::FilterEngine::Prefs& preconfiguredPrefs =
       AdblockPlus::FilterEngine::Prefs())
     {
       AdblockPlus::FilterEngine::CreationParameters createParams;
@@ skipping 23 matching lines @@
 TEST_F(PrefsTest, PrefsPersist)
 {
   {
     auto& filterEngine = CreateFilterEngine();
     ASSERT_EQ(24, filterEngine.GetPref("patternsbackupinterval").AsInt());
     ASSERT_TRUE(filterEngine.GetPref("subscriptions_autoupdate").AsBool());
 
     filterEngine.SetPref("patternsbackupinterval", GetJsEngine().NewValue(48));
     filterEngine.SetPref("subscriptions_autoupdate", GetJsEngine().NewValue(false));
   }
-  ASSERT_FALSE(fileSystem->prefsContents.empty());
+  ASSERT_FALSE(prefsContent.empty());
 
   {
     ResetPlatform();
     auto& filterEngine = CreateFilterEngine();
     ASSERT_EQ(48, filterEngine.GetPref("patternsbackupinterval").AsInt());
     ASSERT_FALSE(filterEngine.GetPref("subscriptions_autoupdate").AsBool());
   }
 }
 
 TEST_F(PrefsTest, UnknownPrefs)
 {
   using IOBuffer = AdblockPlus::IFileSystem::IOBuffer;
   std::string content = "{\"foobar\":2, \"patternsbackupinterval\": 12}";
-  fileSystem->prefsContents = IOBuffer(content.cbegin(), content.cend());
+  prefsContent = IOBuffer(content.cbegin(), content.cend());
   auto& filterEngine = CreateFilterEngine();
   ASSERT_TRUE(filterEngine.GetPref("foobar").IsUndefined());
   ASSERT_EQ(12, filterEngine.GetPref("patternsbackupinterval").AsInt());
 }
 
 TEST_F(PrefsTest, SyntaxFailure)
 {
   using IOBuffer = AdblockPlus::IFileSystem::IOBuffer;
   std::string content = "{\"patternsbackupinterval\": 6, \"foo\"}";
-  fileSystem->prefsContents = IOBuffer(content.cbegin(), content.cend());
+  prefsContent = IOBuffer(content.cbegin(), content.cend());
   ASSERT_EQ(24, CreateFilterEngine().GetPref("patternsbackupinterval").AsInt());
 }
 
 TEST_F(PrefsTest, PreconfiguredPrefsPreconfigured)
 {
   AdblockPlus::FilterEngine::Prefs preconfiguredPrefs;
   preconfiguredPrefs.emplace("disable_auto_updates", GetJsEngine().NewValue(false));
   preconfiguredPrefs.emplace("suppress_first_run_page", GetJsEngine().NewValue(true));
   auto& filterEngine = CreateFilterEngine(preconfiguredPrefs);
 
@@ skipping 27 matching lines @@
 {
   {
     AdblockPlus::FilterEngine::Prefs preconfiguredPrefs;
     preconfiguredPrefs.emplace("suppress_first_run_page", GetJsEngine().NewValue(true));
     auto& filterEngine = CreateFilterEngine(preconfiguredPrefs);
 
     ASSERT_TRUE(filterEngine.GetPref("suppress_first_run_page").IsBool());
     ASSERT_TRUE(filterEngine.GetPref("suppress_first_run_page").AsBool());
     filterEngine.SetPref("suppress_first_run_page", GetJsEngine().NewValue(false));
   }
-  ASSERT_FALSE(fileSystem->prefsContents.empty());
+  ASSERT_FALSE(prefsContent.empty());
 
   {
     ResetPlatform();
     AdblockPlus::FilterEngine::Prefs preconfiguredPrefs;
     preconfiguredPrefs.emplace("suppress_first_run_page", GetJsEngine().NewValue(true));
     auto& filterEngine = CreateFilterEngine(preconfiguredPrefs);
 
     ASSERT_TRUE(filterEngine.GetPref("suppress_first_run_page").IsBool());
     ASSERT_FALSE(filterEngine.GetPref("suppress_first_run_page").AsBool());
   }
 }