Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29535581: Issue 5379 - Remove top level paths from acceptableads.com (Closed)

Created:
Sept. 4, 2017, 11:27 a.m. by juliandoucette
Modified:
Sept. 11, 2017, 4:10 p.m.
Reviewers:
ire
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Issue 5379 - Remove top level paths from acceptableads.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M includes/about/acceptable-ads-are.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/index/what-are-aa/distinction.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/index/what-are-aa/placement.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/index/what-are-aa/size.md View 1 chunk +1 line, -1 line 0 comments Download
M includes/index/who-benefits/ad-networks.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/index/who-benefits/ad-tech-suppliers.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/index/who-benefits/advertisers.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/index/who-benefits/publishers.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/index/who-benefits/users.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/solutions/ad-networks.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/solutions/ad-tech-suppliers.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/solutions/advertisers.md View 1 chunk +2 lines, -2 lines 0 comments Download
M includes/solutions/publishers.md View 1 chunk +2 lines, -2 lines 0 comments Download
M pages/solutions/ad-networks.md View 1 chunk +1 line, -1 line 0 comments Download
M pages/solutions/ad-tech-suppliers.md View 1 chunk +1 line, -1 line 0 comments Download
M pages/solutions/advertisers.md View 1 chunk +1 line, -1 line 0 comments Download
M pages/solutions/publishers.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
juliandoucette
Sept. 4, 2017, 11:27 a.m. (2017-09-04 11:27:46 UTC) #1
juliandoucette
I didn't change the image paths because our test_server doesn't resolve internationalized images properly atm ...
Sept. 4, 2017, 11:36 a.m. (2017-09-04 11:36:32 UTC) #2
ire
Sept. 6, 2017, 10:06 p.m. (2017-09-06 22:06:15 UTC) #3
LGTM

On 2017/09/04 11:36:32, juliandoucette wrote:
> I didn't change the image paths because our test_server doesn't resolve
> internationalized images properly atm (they don't fall-back to English). I
think
> we can separate the page links issue from the image paths issue here.

I think we should update the ticket on Trac so this is clear

Powered by Google App Engine
This is Rietveld